Bence Pőcze bence
0 Followers · 2 Following
  • Joined on 2020-12-27
Repositories
2
 Projects Packages Public Activity Starred Repositories
1
bence pushed to develop at esoko/mapguesser 2021-05-29 10:22:20 +02:00
272ec3568d Merge pull request 'bugfix/MAPG-240-fix-static-code-analysis-errors' (!49) from bugfix/MAPG-240-fix-static-code-analysis-errors into develop
be4a2038e5 MAPG-240 add use for PlaceInChallenge (used in MapAdminController::deleteChallenge)
f305c97513 MAPG-240 UserInChallengeRepository::isUserParticipatingInChallenge should return bool
Compare 3 commits »
bence created pull request esoko/mapguesser#49 2021-05-29 01:00:27 +02:00
bugfix/MAPG-240-fix-static-code-analysis-errors
be4a2038e5 MAPG-240 add use for PlaceInChallenge (used in MapAdminController::deleteChallenge)
f305c97513 MAPG-240 UserInChallengeRepository::isUserParticipatingInChallenge should return bool
Compare 2 commits »
bence created branch bugfix/MAPG-240-fix-static-code-analysis-errors in esoko/mapguesser 2021-05-29 00:51:50 +02:00
bence deleted branch feature/MAPG-235-basic-challenge-mode from esoko/mapguesser 2021-05-29 00:16:23 +02:00
bence pushed tag Release_2105.6 to esoko/mapguesser 2021-05-28 21:28:46 +02:00
bence approved esoko/mapguesser#48 2021-05-28 20:24:35 +02:00
feature/MAPG-235-basic-challenge-mode
bence commented on pull request esoko/mapguesser#48 2021-05-28 20:24:14 +02:00
feature/MAPG-235-basic-challenge-mode

I think Websocket is not really necessary for that, it could be implemented without "active" connection. For example we could store a timestamp for each guess and calculate the difference between the…

bence commented on pull request esoko/mapguesser#48 2021-05-27 23:40:16 +02:00
feature/MAPG-235-basic-challenge-mode

Yes, I meant later, it will be a bigger task.

bence commented on pull request esoko/mapguesser#48 2021-05-27 23:39:14 +02:00
feature/MAPG-235-basic-challenge-mode

It could be solved with a hidden element, for example with class hidden which can be removed by JavaScript when it should be shown (it still can have class hideOnNarrowScreen). But I think it is…

bence commented on pull request esoko/mapguesser#48 2021-05-27 23:34:32 +02:00
feature/MAPG-235-basic-challenge-mode

I think some of the rules should be handled on higher level, for example font-family in mapguesser.css line 34,

bence commented on pull request esoko/mapguesser#48 2021-05-27 23:22:04 +02:00
feature/MAPG-235-basic-challenge-mode

This highscore table could be implemented for multiplayer in the future.

bence commented on pull request esoko/mapguesser#48 2021-05-27 23:20:45 +02:00
feature/MAPG-235-basic-challenge-mode

So actually users can cheat with this if they send a bigger number back :D

bence commented on pull request esoko/mapguesser#48 2021-05-27 23:16:29 +02:00
feature/MAPG-235-basic-challenge-mode

This file should be refactored sometime because it is very spaghetti :D

bence commented on pull request esoko/mapguesser#48 2021-05-27 23:09:13 +02:00
feature/MAPG-235-basic-challenge-mode

PHP's builtin ctype_xdigit could be used for that.

bence commented on pull request esoko/mapguesser#48 2021-05-27 23:06:31 +02:00
feature/MAPG-235-basic-challenge-mode

I think rand() should be called with explicit arguments, otherwise a number is returned between 0 and getrandmax() and getrandmax() is platform-dependent.

bence commented on pull request esoko/mapguesser#48 2021-05-27 22:56:17 +02:00
feature/MAPG-235-basic-challenge-mode

Maybe a do..while would be better here because the token calculation should not be repeated.

bence commented on pull request esoko/mapguesser#48 2021-05-25 18:13:59 +02:00
feature/MAPG-235-basic-challenge-mode

Gamma :D

bence commented on pull request esoko/mapguesser#48 2021-05-25 18:13:16 +02:00
feature/MAPG-235-basic-challenge-mode