Block a user
bence
deleted branch feature/preference-for-outdoor-panorama-in-the-frontend from esoko/mapguesser
2021-05-09 13:34:41 +02:00
reverted removal of preference for outdoor panorama in the front end
94624d5b2c
Merge pull request 'reverted removal of preference for outdoor panorama in the front end' (#43) from feature/preference-for-outdoor-panorama-in-the-frontend into develop
feature/avoid-repeating-places-in-game
Really good feature, thank you for implementing this! I just had some minor findings.
feature/avoid-repeating-places-in-game
I would check if count($unvisitedPlaces) == $n before calling this function so we could save a function call and a DB query in a lot of cases.
feature/avoid-repeating-places-in-game
I wouldn't reformat this. There is no official coding guideline but I usually put a space after if, while, for, etc.
feature/avoid-repeating-places-in-game
This can be private now. And I don't remember why it has a parameter $exclude but I would remove that for a better understaning and create a local variable instead.
feature/avoid-repeating-places-in-game
If it is refactored anyway I would directly use $this->joins and local variable $joins (line 331) becomes unnecessary.
feature/avoid-repeating-places-in-game
Better to use $array[] = to add a new element to an array because it is more efficient according the the PHP docs:
bence
deleted branch feature/more-accurate-new-selection-in-mapeditor-on-google-maps from esoko/mapguesser
2021-05-02 19:45:26 +02:00