Bence Pőcze bence
0 Followers · 2 Following
  • Joined on 2020-12-27
Repositories
2
 Projects Packages Public Activity Starred Repositories
1
bence pushed to feature/place-streetview-cover-to-the-map at esoko/mapguesser 2021-05-02 15:04:35 +02:00
c112a25409 move street view cover button to the map as circleControl
35cab17c21 make circle control items more general
c4c03d5dfb move street view cover button to the map as circleControl
26c5a78b90 make circle control items more general
Compare 4 commits »
bence pushed to feature/place-streetview-cover-to-the-map at esoko/mapguesser 2021-05-02 14:54:11 +02:00
c4c03d5dfb move street view cover button to the map as circleControl
26c5a78b90 make circle control items more general
700d349d38 move street view cover button to the map as circleControl
2edfd14437 make circle control items more general
f9c1829a00 enable zoomControl for Leaflet map to be consistent with Google map
Compare 6 commits »
bence created branch feature/place-streetview-cover-to-the-map in esoko/mapguesser 2021-05-02 14:53:08 +02:00
bence pushed to feature/place-streetview-cover-to-the-map at esoko/mapguesser 2021-05-02 14:53:08 +02:00
700d349d38 move street view cover button to the map as circleControl
2edfd14437 make circle control items more general
Compare 2 commits »
bence created pull request esoko/mapguesser#34 2021-05-02 13:47:20 +02:00
bugfix/streetviewcontrol-is-still-visible
bence created branch bugfix/streetviewcontrol-is-still-visible in esoko/mapguesser 2021-05-02 13:45:40 +02:00
bence pushed to bugfix/streetviewcontrol-is-still-visible at esoko/mapguesser 2021-05-02 13:45:40 +02:00
f9c1829a00 enable zoomControl for Leaflet map to be consistent with Google map
e03850ce05 switch off streetViewControl explicitly
Compare 2 commits »
bence pushed tag Release_2105.1 to esoko/mapguesser 2021-05-02 13:39:36 +02:00
bence deleted branch feature/google-maps-in-mapeditor-added from esoko/mapguesser 2021-05-02 13:38:25 +02:00
bence merged pull request esoko/mapguesser#33 2021-05-02 13:38:17 +02:00
feature/google-maps-in-mapeditor-added
bence pushed to develop at esoko/mapguesser 2021-05-02 13:38:17 +02:00
55ec226407 Merge pull request 'feature/google-maps-in-mapeditor-added' (#33) from feature/google-maps-in-mapeditor-added into develop
6ef04fcd4e fit both google and leaflet map to bounds if map already exists
3045d8acbb remove builtin streetViewControl from google map
19a1b79b0a toggling of street view cover added
d432a5b584 cleaned up the comment
Compare 10 commits »
bence approved esoko/mapguesser#33 2021-05-02 13:30:29 +02:00
feature/google-maps-in-mapeditor-added
bence pushed to feature/google-maps-in-mapeditor-added at esoko/mapguesser 2021-05-02 13:30:00 +02:00
6ef04fcd4e fit both google and leaflet map to bounds if map already exists
3045d8acbb remove builtin streetViewControl from google map
Compare 2 commits »
bence approved esoko/mapguesser#33 2021-05-02 12:48:34 +02:00
feature/google-maps-in-mapeditor-added
bence commented on pull request esoko/mapguesser#33 2021-05-02 12:47:35 +02:00
feature/google-maps-in-mapeditor-added

For me it's OK, then it can be done later.

bence commented on pull request esoko/mapguesser#33 2021-05-02 12:01:18 +02:00
feature/google-maps-in-mapeditor-added

It is a very good feature because it seems that the editor is easier to use with Google Maps. Maybe it won't be neccessary to keep the Leaflet version at all so it might be removed in the future.

bence commented on pull request esoko/mapguesser#33 2021-05-02 11:57:30 +02:00
feature/google-maps-in-mapeditor-added

PNG files (as these are binaries) should be stored with git-lfs. I think you don't have git-lfs on your machine, otherwise they would have been committed that way.

Example if files are stored with…

bence created branch git-lfs-example in esoko/mapguesser 2021-05-02 11:40:18 +02:00
bence pushed to git-lfs-example at esoko/mapguesser 2021-05-02 11:40:18 +02:00
91f430c3c0 organised Leaflet map and Google Maps into wrappers
bence commented on pull request esoko/mapguesser#33 2021-05-02 11:28:47 +02:00
feature/google-maps-in-mapeditor-added

I would remove this and add a permanent street view cover layer to the map so the available locations will be always shown. (This is the same how the competitor does.)