esoko/mapguesser
esoko/mapguesser
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 18 Wiki Activity

MAPG-203 remove placesWithoutPano logic from PlaceRepository

Browse Source
This commit is contained in:
Bence Pőcze 2021-03-15 12:25:49 +01:00
parent bf27f15709
commit 2c4d809d49
Signed by: bence
GPG Key ID: AA52B11A3269D1C1
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Repository/PlaceRepository.php
View File

@ -29,17 +29,14 @@ class PlaceRepository
}
//TODO: use Map instead of id
public function getRandomForMapWithValidPano(int $mapId, array $exclude = [], array &$placesWithoutPano): Place
public function getRandomForMapWithValidPano(int $mapId, array $exclude = []): Place
{
$placesWithoutPano = [];
do {
$place = $this->selectRandomFromDbForMap($mapId, $exclude);
$panoId = $place->getFreshPanoId();
if ($panoId === null) {
$placesWithoutPano[] = $exclude[] = $place->getId();
$exclude[] = $place->getId();
}
} while ($panoId === null);