esoko/mapguesser
1
1 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 18 Wiki Activity

MAPG-191 don't create separate variable for data where not necessary

Browse Source
This commit is contained in:
bence committed 2020-07-05 00:58:03 +02:00
1 parent e17cf68007
commit 6db6208896
8 files changed
+170 -132
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/Controller/GameFlowController.php
+4 -7
View File
@@ -29,8 +29,7 @@ class GameFlowController
$session = $this->request->session();
if (!($state = $session->get('state')) || $state['mapId'] !== $mapId) {
$data = ['error' => 'no_session_found'];
return new JsonContent($data);
return new JsonContent(['error' => 'no_session_found']);
}
if (count($state['rounds']) === 0) {
@@ -79,8 +78,7 @@ class GameFlowController
$session = $this->request->session();
if (!($state = $session->get('state')) || $state['mapId'] !== $mapId) {
$data = ['error' => 'no_session_found'];
return new JsonContent($data);
return new JsonContent(['error' => 'no_session_found']);
}
$last = $state['rounds'][count($state['rounds']) - 1];
@@ -119,7 +117,7 @@ class GameFlowController
$session->set('state', $state);
$data = [
return new JsonContent([
'result' => [
'position' => $position->toArray(),
'distance' => $distance,
@@ -127,8 +125,7 @@ class GameFlowController
],
'panoId' => $panoId,
'pov' => $pov
];
return new JsonContent($data);
]);
}
private function addNewRoundToState(&$state, Place $place, array $placesWithoutPano): void