MAPG-191 don't create separate variable for data where not necessary
This commit is contained in:
8 files changed
+170
-132
No files matched your search
@@ -58,8 +58,13 @@ class MapAdminController implements ISecured
|
||||
$places = [];
|
||||
}
|
||||
|
||||
$data = ['mapId' => $mapId, 'mapName' => $map->getName(), 'mapDescription' => str_replace('<br>', "\n", $map->getDescription()), 'bounds' => $map->getBounds()->toArray(), 'places' => &$places];
|
||||
return new HtmlContent('admin/map_editor', $data);
|
||||
return new HtmlContent('admin/map_editor', [
|
||||
'mapId' => $mapId,
|
||||
'mapName' => $map->getName(),
|
||||
'mapDescription' => str_replace('<br>', "\n", $map->getDescription()),
|
||||
'bounds' => $map->getBounds()->toArray(),
|
||||
'places' => &$places
|
||||
]);
|
||||
}
|
||||
|
||||
public function getPlace(): IContent
|
||||
@@ -68,8 +73,7 @@ class MapAdminController implements ISecured
|
||||
|
||||
$place = $this->placeRepository->getById($placeId);
|
||||
|
||||
$data = ['panoId' => $place->getFreshPanoId()];
|
||||
return new JsonContent($data);
|
||||
return new JsonContent(['panoId' => $place->getFreshPanoId()]);
|
||||
}
|
||||
|
||||
public function saveMap(): IContent
|
||||
@@ -157,8 +161,7 @@ class MapAdminController implements ISecured
|
||||
|
||||
\Container::$dbConnection->commit();
|
||||
|
||||
$data = ['mapId' => $map->getId(), 'added' => $addedIds];
|
||||
return new JsonContent($data);
|
||||
return new JsonContent(['mapId' => $map->getId(), 'added' => $addedIds]);
|
||||
}
|
||||
|
||||
public function deleteMap()
|
||||
@@ -175,8 +178,7 @@ class MapAdminController implements ISecured
|
||||
|
||||
\Container::$dbConnection->commit();
|
||||
|
||||
$data = ['success' => true];
|
||||
return new JsonContent($data);
|
||||
return new JsonContent(['success' => true]);
|
||||
}
|
||||
|
||||
private function deletePlaces(Map $map): void
|
||||
|
||||
Reference in new issue
Block a user