From c06dd1e1d2d8cea22ff506411443a87ab9b08e9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C5=91cze=20Bence?= <bence@pocze.ch>
Date: Fri, 26 Jun 2020 00:02:24 +0200
Subject: [PATCH] MAPG-177 refactor GoogleOAuth, Http\Request, Http\Response to
 be more testable

---
 src/Controller/LoginController.php |  5 +++--
 src/Http/Request.php               | 23 ++++++++++++++++-------
 src/Http/Response.php              |  4 +++-
 src/Interfaces/Http/IRequest.php   | 18 ++++++++++++++++++
 src/Interfaces/Http/IResponse.php  |  8 ++++++++
 src/OAuth/GoogleOAuth.php          | 16 ++++++++++++----
 6 files changed, 60 insertions(+), 14 deletions(-)
 create mode 100644 src/Interfaces/Http/IRequest.php
 create mode 100644 src/Interfaces/Http/IResponse.php

diff --git a/src/Controller/LoginController.php b/src/Controller/LoginController.php
index 82592c2..fb5573a 100644
--- a/src/Controller/LoginController.php
+++ b/src/Controller/LoginController.php
@@ -1,5 +1,6 @@
 <?php namespace MapGuesser\Controller;
 
+use MapGuesser\Http\Request;
 use MapGuesser\Interfaces\Request\IRequest;
 use MapGuesser\Interfaces\Response\IContent;
 use MapGuesser\Interfaces\Response\IRedirect;
@@ -49,7 +50,7 @@ class LoginController
 
         $this->request->session()->set('oauth_state', $state);
 
-        $oAuth = new GoogleOAuth();
+        $oAuth = new GoogleOAuth(new Request());
         $url = $oAuth->getDialogUrl($state, $this->request->getBase() . '/' . \Container::$routeCollection->getRoute('login-google-action')->generateLink());
 
         return new Redirect($url, IRedirect::TEMPORARY);
@@ -147,7 +148,7 @@ class LoginController
             return new HtmlContent('login/google_login', $data);
         }
 
-        $oAuth = new GoogleOAuth();
+        $oAuth = new GoogleOAuth(new Request());
         $tokenData = $oAuth->getToken($this->request->query('code'), $this->request->getBase() . '/' . \Container::$routeCollection->getRoute('login-google-action')->generateLink());
 
         if (!isset($tokenData['id_token'])) {
diff --git a/src/Http/Request.php b/src/Http/Request.php
index 2e5426a..9f1a05b 100644
--- a/src/Http/Request.php
+++ b/src/Http/Request.php
@@ -1,11 +1,10 @@
 <?php namespace MapGuesser\Http;
 
-class Request
+use MapGuesser\Interfaces\Http\IRequest;
+use MapGuesser\Interfaces\Http\IResponse;
+
+class Request implements IRequest
 {
-    const HTTP_GET = 0;
-
-    const HTTP_POST = 1;
-
     private string $url;
 
     private int $method;
@@ -14,12 +13,22 @@ class Request
 
     private array $headers = [];
 
-    public function __construct(string $url, int $method = self::HTTP_GET)
+    public function __construct(string $url = '', int $method = self::HTTP_GET)
     {
         $this->url = $url;
         $this->method = $method;
     }
 
+    public function setUrl(string $url): void
+    {
+        $this->url = $url;
+    }
+
+    public function setMethod(int $method): void
+    {
+        $this->method = $method;
+    }
+
     public function setQuery($query)
     {
         if (is_string($query)) {
@@ -34,7 +43,7 @@ class Request
         $this->headers = array_merge($this->headers, $headers);
     }
 
-    public function send(): Response
+    public function send(): IResponse
     {
         $ch = curl_init();
 
diff --git a/src/Http/Response.php b/src/Http/Response.php
index 9bee447..65958b0 100644
--- a/src/Http/Response.php
+++ b/src/Http/Response.php
@@ -1,6 +1,8 @@
 <?php namespace MapGuesser\Http;
 
-class Response
+use MapGuesser\Interfaces\Http\IResponse;
+
+class Response implements IResponse
 {
     private string $body;
 
diff --git a/src/Interfaces/Http/IRequest.php b/src/Interfaces/Http/IRequest.php
new file mode 100644
index 0000000..10436f7
--- /dev/null
+++ b/src/Interfaces/Http/IRequest.php
@@ -0,0 +1,18 @@
+<?php namespace MapGuesser\Interfaces\Http;
+
+interface IRequest
+{
+    const HTTP_GET = 0;
+
+    const HTTP_POST = 1;
+
+    public function setUrl(string $url): void;
+
+    public function setMethod(int $method): void;
+
+    public function setQuery($query);
+
+    public function setHeaders(array $headers);
+
+    public function send(): IResponse;
+}
diff --git a/src/Interfaces/Http/IResponse.php b/src/Interfaces/Http/IResponse.php
new file mode 100644
index 0000000..b840bac
--- /dev/null
+++ b/src/Interfaces/Http/IResponse.php
@@ -0,0 +1,8 @@
+<?php namespace MapGuesser\Interfaces\Http;
+
+interface IResponse
+{
+    public function getBody();
+
+    public function getHeaders();
+}
diff --git a/src/OAuth/GoogleOAuth.php b/src/OAuth/GoogleOAuth.php
index 07c2107..c339179 100644
--- a/src/OAuth/GoogleOAuth.php
+++ b/src/OAuth/GoogleOAuth.php
@@ -1,6 +1,6 @@
 <?php namespace MapGuesser\OAuth;
 
-use MapGuesser\Http\Request;
+use MapGuesser\Interfaces\Http\IRequest;
 
 class GoogleOAuth
 {
@@ -8,6 +8,13 @@ class GoogleOAuth
 
     private static $tokenUrlBase = 'https://oauth2.googleapis.com/token';
 
+    private IRequest $request;
+
+    public function __construct(IRequest $request)
+    {
+        $this->request = $request;
+    }
+
     public function getDialogUrl(string $state, string $redirectUrl): string
     {
         $oauthParams = [
@@ -32,9 +39,10 @@ class GoogleOAuth
             'grant_type' => 'authorization_code',
         ];
 
-        $request = new Request(self::$tokenUrlBase, Request::HTTP_POST);
-        $request->setQuery($tokenParams);
-        $response = $request->send();
+        $this->request->setUrl(self::$tokenUrlBase);
+        $this->request->setMethod(IRequest::HTTP_POST);
+        $this->request->setQuery($tokenParams);
+        $response = $this->request->send();
 
         return json_decode($response->getBody(), true);
     }