remove unnecessary startTransaction and commit calls

src/Controller/LoginController.php

@@ -346,8 +346,6 @@ class LoginController
         $user->setPlainPassword($this->request->post('password'));
         $user->setCreatedDate(new DateTime());
 
-        \Container::$dbConnection->startTransaction();
-
         $this->pdm->saveToDb($user);
 
         $token = bin2hex(random_bytes(16));
@@ -359,8 +357,6 @@ class LoginController
 
         $this->pdm->saveToDb($confirmation);
 
-        \Container::$dbConnection->commit();
-
         $this->sendConfirmationEmail($user->getEmail(), $token, $user->getCreatedDate());
 
         $this->request->session()->delete('tmp_user_data');
@@ -432,8 +428,6 @@ class LoginController
             return new HtmlContent('login/activate');
         }
 
-        \Container::$dbConnection->startTransaction();
-
         $this->pdm->deleteFromDb($confirmation);
 
         $user = $this->userRepository->getById($confirmation->getUserId());
@@ -441,8 +435,6 @@ class LoginController
 
         $this->pdm->saveToDb($user);
 
-        \Container::$dbConnection->commit();
-
         $this->request->setUser($user);
 
         $this->deleteRedirectUrl();
@@ -462,8 +454,6 @@ class LoginController
             return new HtmlContent('login/cancel', ['success' => false]);
         }
 
-        \Container::$dbConnection->startTransaction();
-
         $this->pdm->deleteFromDb($confirmation);
 
         $user = $this->userRepository->getById($confirmation->getUserId());
@@ -474,8 +464,6 @@ class LoginController
 
         $this->pdm->deleteFromDb($user);
 
-        \Container::$dbConnection->commit();
-
         return new HtmlContent('login/cancel', ['success' => true]);
     }
 
@@ -541,16 +529,12 @@ class LoginController
         $passwordResetter->setToken($token);
         $passwordResetter->setExpiresDate($expires);
 
-        \Container::$dbConnection->startTransaction();
-
         if ($existingResetter !== null) {
             $this->pdm->deleteFromDb($existingResetter);
         }
 
         $this->pdm->saveToDb($passwordResetter);
 
-        \Container::$dbConnection->commit();
-
         $this->sendPasswordResetEmail($user->getEmail(), $token, $expires);
 
         return new JsonContent(['success' => true]);
@@ -591,8 +575,6 @@ class LoginController
             return new JsonContent(['error' => ['errorText' => 'The given passwords do not match.']]);
         }
 
-        \Container::$dbConnection->startTransaction();
-
         $this->pdm->deleteFromDb($resetter);
 
         $user = $this->userRepository->getById($resetter->getUserId());
@@ -600,8 +582,6 @@ class LoginController
 
         $this->pdm->saveToDb($user);
 
-        \Container::$dbConnection->commit();
-
         $this->request->setUser($user);
 
         $this->deleteRedirectUrl();