Merge pull request 'MAPG-229 make .controlItem relative so it's children can be sized more properly' (#45) from bugfix/MAPG-229-circle-controls-won-t-show-up-in-firefox into develop

Reviewed-on: https://gitea.e5tv.hu/esoko/mapguesser/pulls/45

README.md

@@ -70,6 +70,7 @@ Example:
 ```
 LEAFLET_TILESERVER_URL=https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png
 LEAFLET_TILESERVER_SUBDOMAINS=abc
+LEAFLET_TILESERVER_ATTRIBUTION="&copy; <a href=\"https://www.openstreetmap.org/copyright\">OpenStreetMap</a> contributors"
 ```
 
 ### (Production only) Create cron job

public/static/css/mapguesser.css

@@ -451,6 +451,7 @@ div.box {
 }
 
 .circleControl .controlItem {
+    position: relative;
     height: 60px;
     margin-top: 10px;
     opacity: 70%;
@@ -463,6 +464,8 @@ div.box {
 
 .circleControl .controlItem div {
     position: absolute;
+    width: 100%;
+    height: 100%;
 }
 
 .circleControl .controlBackground {
@@ -477,7 +480,6 @@ div.box {
     margin: auto;
     margin-top: 50%;
     transform: translateY(-50%);
-    -ms-transform: translateY(-50%);
 }
 
 @media screen and (max-width: 599px) {

public/static/js/map_editor.js

@@ -80,16 +80,22 @@
             MapEditor.panorama.setPano(panoLocationData.pano);
         },
 
-        requestPanoData: function (location) {
+        requestPanoData: function (location, canBeIndoor) {
             var sv = new google.maps.StreetViewService();
 
             sv.getPanorama({
                 location: location,
                 preference: google.maps.StreetViewPreference.NEAREST,
                 radius: MapEditor.map.getSearchRadius(location),
+                source: canBeIndoor ? google.maps.StreetViewSource.DEFAULT : google.maps.StreetViewSource.OUTDOOR
             }, function (data, status) {
                 var panoLocationData = status === google.maps.StreetViewStatus.OK ? data.location : null;
 
+                if (panoLocationData === null && !canBeIndoor) {	
+                    MapEditor.requestPanoData(location, true);	
+                    return;	
+                }
+
                 document.getElementById('loading').style.visibility = 'hidden';
 
                 MapEditor.loadPanoForNewPlace(panoLocationData);

web.php

@@ -74,13 +74,23 @@ if (isset($_COOKIE['COOKIES_CONSENT'])) {
 
     session_set_save_handler(Container::$sessionHandler, true);
     session_start([
-        'gc_maxlifetime' => 604800,
         'gc_probability' => 0, // old sessions are deleted by MaintainDatabaseCommand
-        'cookie_lifetime' => 604800, // TODO: cookie is not renewed so session can be lost
+        'cookie_lifetime' => 604800,
+        'cookie_path' => '/',
         'cookie_httponly' => true,
         'cookie_samesite' => 'Lax'
     ]);
 
+    if (isset($_COOKIE[session_name()])) {
+        // extend session cookie lifetime is cookie already exists
+        setcookie(session_name(), session_id(), [
+            'expires' => time() + 604800,
+            'path' => '/',
+            'httponly' => true,
+            'samesite' => 'Lax'
+        ]);
+    }
+
     // this is needed to handle old type of session IDs
     if (!Container::$sessionHandler->validateId(session_id())) {
         session_regenerate_id(true);