cleaned up the comment

public/static/css/map_editor.css

@@ -1,4 +1,4 @@
-#map {
+.map {
     position: absolute;
     top: 0;
     left: 0;
@@ -7,6 +7,13 @@
     z-index: 1;
 }
 
+#mapSelection img {
+    display: inline;
+    width: 1em;
+    height: 1em;
+    vertical-align: -0.15em;
+}
+
 /* modify the cursor for the Leaflet map */
 .leaflet-container {
     cursor: crosshair;
@@ -65,6 +72,9 @@
     #placeControl {
         top: calc(50% + 10px);
     }
+    .hideOnMobile {
+        display: none;
+    }
 }
 
 @media screen and (min-width: 1000px), (max-height: 599px) {

public/static/img/map.svg

@@ -0,0 +1,4 @@
+<!-- Copyright (c) 2019 The Bootstrap Authors. License can be found in 'USED_SOFTWARE' in section 'Bootstrap Icons'. -->
+<svg xmlns="http://www.w3.org/2000/svg" fill="#ffffff" viewBox="0 0 16 16">
+  <path fill-rule="evenodd" d="M15.817.113A.5.5 0 0 1 16 .5v14a.5.5 0 0 1-.402.49l-5 1a.502.502 0 0 1-.196 0L5.5 15.01l-4.902.98A.5.5 0 0 1 0 15.5v-14a.5.5 0 0 1 .402-.49l5-1a.5.5 0 0 1 .196 0L10.5.99l4.902-.98a.5.5 0 0 1 .415.103zM10 1.91l-4-.8v12.98l4 .8V1.91zm1 12.98 4-.8V1.11l-4 .8v12.98zm-6-.8V1.11l-4 .8v12.98l4-.8z"/>
+</svg>

public/static/js/map_editor.js

@@ -117,7 +117,7 @@
             MapEditor.resetSelected();
             MapEditor.selectedMarker = marker;
 
-            MapEditor.map.invalidateSize(true);
+            MapEditor.map.resize();
             MapEditor.map.panTo(marker.getLatLng());
 
             MapEditor.panorama.setVisible(false);
@@ -219,7 +219,7 @@
             MapEditor.resetSelected(del);
             MapEditor.selectedMarker = null;
 
-            MapEditor.map.invalidateSize(true);
+            MapEditor.map.resize();
         },
 
         deletePlace: function () {
@@ -235,6 +235,7 @@
 
             delete MapEditor.added[placeId];
             delete MapEditor.edited[placeId];
+            delete places[placeId];
 
             document.getElementById('added').innerHTML = String(Object.keys(MapEditor.added).length);
             document.getElementById('edited').innerHTML = String(Object.keys(MapEditor.edited).length);
@@ -350,6 +351,7 @@
     var LMapWrapper = {
         map: null,
         markers: null,
+        divId: null,
         iconCollection: {
             iconGreen: L.icon({
                 iconUrl: STATIC_ROOT + '/img/markers/marker-green.svg?rev' + REVISION,
@@ -369,36 +371,48 @@
         },
 
         init: function (divId, places) {
-            LMapWrapper.map = L.map('map', {
+            document.getElementById(divId).style.display = "block";
-                zoomControl: false
-            });
 
-            LMapWrapper.map.on('click', function (e) {
+            if (!LMapWrapper.map) {
-                LMapWrapper.placeMarker(e.latlng);
+                LMapWrapper.divId = divId;
-            });
+                LMapWrapper.map = L.map(LMapWrapper.divId, {
+                    zoomControl: false
+                });
 
-            var highResData = Util.getHighResData();
+                LMapWrapper.map.on('click', function (e) {
+                    LMapWrapper.placeMarker(e.latlng);
+                });
 
-            L.tileLayer(tileUrl, {
+                var highResData = Util.getHighResData();
-                attribution: tileAttribution,
-                subdomains: '1234',
-                ppi: highResData.ppi,
-                tileSize: highResData.tileSize,
-                zoomOffset: highResData.zoomOffset,
-                minZoom: highResData.minZoom,
-                maxZoom: highResData.maxZoom
-            }).addTo(LMapWrapper.map);
 
-            LMapWrapper.map.fitBounds(L.latLngBounds({ lat: mapBounds.south, lng: mapBounds.west }, { lat: mapBounds.north, lng: mapBounds.east }));
+                L.tileLayer(tileUrl, {
+                    attribution: tileAttribution,
+                    subdomains: '1234',
+                    ppi: highResData.ppi,
+                    tileSize: highResData.tileSize,
+                    zoomOffset: highResData.zoomOffset,
+                    minZoom: highResData.minZoom,
+                    maxZoom: highResData.maxZoom
+                }).addTo(LMapWrapper.map);
+
+                LMapWrapper.map.fitBounds(L.latLngBounds({ lat: mapBounds.south, lng: mapBounds.west }, { lat: mapBounds.north, lng: mapBounds.east }));
+            }
 
             LMapWrapper.loadMarkers(places);
         },
 
-        loadMarkers: function (places) {
+        hide: function () {
+            document.getElementById(LMapWrapper.divId).style.display = 'none';
+        },
 
-            LMapWrapper.markers = L.markerClusterGroup({
+        loadMarkers: function (places) {
-                maxClusterRadius: 50
+            if (!LMapWrapper.markers) {
-            });
+                LMapWrapper.markers = L.markerClusterGroup({
+                    maxClusterRadius: 50
+                });
+            } else {
+                LMapWrapper.markers.clearLayers();
+            }
 
             for (var placeId in places) {
                 if (!places.hasOwnProperty(placeId)) {
@@ -416,7 +430,7 @@
                         MapEditor.select(this);
                     });
 
-                marker.placeId = place.id;
+                marker.placeId = placeId;
             }
 
             LMapWrapper.map.addLayer(LMapWrapper.markers);
@@ -429,7 +443,7 @@
                 icon: LMapWrapper.iconCollection.iconBlue,
                 zIndexOffset: 2000
             })
-                .addTo(LMapWrapper.map)
+                .addTo(LMapWrapper.markers)
                 .on('click', function () {
                     MapEditor.select(this);
                 });
@@ -441,25 +455,24 @@
             LMapWrapper.map.panTo(latLng);
         },
 
-        invalidateSize: function (invalid) {
+        resize: function () {
-            LMapWrapper.map.invalidateSize(invalid);
+            LMapWrapper.map.invalidateSize(true);
         },
 
         changeMarkerIcon: function (marker, icon) {
-            LMapWrapper.markers.removeLayer(marker);
-            LMapWrapper.map.addLayer(marker);
             marker.setIcon(icon);
             marker.setZIndexOffset(2000);
         },
 
         removeMarker: function (marker) {
-            LMapWrapper.map.removeLayer(marker);
+            LMapWrapper.markers.removeLayer(marker);
         }
     };
 
     var GMapWrapper = {
         map: null,
         markers: null,
+        divId: null,
         iconCollection: {
             iconGreen: {
                 url: STATIC_ROOT + '/img/markers/marker-green.svg?rev' + REVISION,
@@ -482,36 +495,52 @@
         },
 
         init: function (divId, places) {
-            GMapWrapper.map = new google.maps.Map(document.getElementById(divId), {
+            document.getElementById(divId).style.display = "block";
-                center: { lat: 48.2207779, lng: 16.3098489 },
-                zoom: 2,
-                fullscreenControl: false,
-                zoomControl: true,
-                zoomControlOptions: {
-                    position: google.maps.ControlPosition.LEFT_BOTTOM
-                },
-                streetViewControl: true,
-                streetViewControlOptions: {
-                    position: google.maps.ControlPosition.LEFT_BOTTOM
-                },
-                draggableCursor: 'crosshair'
-            });
 
-            GMapWrapper.map.addListener('click', function (mapsMouseEvent) {
+            if (!GMapWrapper.map) {
-                GMapWrapper.placeMarker({
+                GMapWrapper.divId = divId;
-                    lat: mapsMouseEvent.latLng.lat(),
+                GMapWrapper.map = new google.maps.Map(document.getElementById(GMapWrapper.divId), {
-                    lng: mapsMouseEvent.latLng.lng()
+                    center: { lat: 0., lng: 0. },
+                    zoom: 2,
+                    fullscreenControl: false,
+                    zoomControl: true,
+                    zoomControlOptions: {
+                        position: google.maps.ControlPosition.LEFT_BOTTOM
+                    },
+                    streetViewControl: true,
+                    streetViewControlOptions: {
+                        position: google.maps.ControlPosition.LEFT_BOTTOM
+                    },
+                    draggableCursor: 'crosshair'
                 });
-            });
+
+                GMapWrapper.map.addListener('click', function (mapsMouseEvent) {
+                    GMapWrapper.placeMarker({
+                        lat: mapsMouseEvent.latLng.lat(),
+                        lng: mapsMouseEvent.latLng.lng()
+                    });
+                });
+
+            }
 
             GMapWrapper.loadMarkers(places);
+
+            GMapWrapper.loaded = true;
+        },
+
+        hide: function () {
+            document.getElementById(GMapWrapper.divId).style.display = 'none';
         },
 
         loadMarkers: function (places) {
-            GMapWrapper.markers = new MarkerClusterer(GMapWrapper.map, [], { 
+            if (!GMapWrapper.markers) {
-                imagePath: STATIC_ROOT + '/img/markers/m',
+                GMapWrapper.markers = new MarkerClusterer(GMapWrapper.map, [], {
-                imageExtension: 'png?rev' + REVISION
+                    imagePath: STATIC_ROOT + '/img/markers/m',
-            });
+                    imageExtension: 'png?rev' + REVISION
+                });
+            } else {
+                GMapWrapper.markers.clearMarkers();
+            }
 
             for (var placeId in places) {
                 if (!places.hasOwnProperty(placeId)) {
@@ -535,7 +564,7 @@
                     MapEditor.select(this);
                 });
 
-                marker.placeId = place.id;
+                marker.placeId = placeId;
 
                 GMapWrapper.markers.addMarker(marker);
             }
@@ -566,10 +595,8 @@
             GMapWrapper.map.panTo(latLng);
         },
 
-        invalidateSize: function (invalid) {
+        resize: function () {
-            if (invalid) {
+            google.maps.event.trigger(GMapWrapper.map, 'resize');
-                google.maps.event.trigger(GMapWrapper.map, 'resize');
-            }
         },
 
         changeMarkerIcon: function (marker, icon) {
@@ -581,9 +608,9 @@
         }
     };
 
-    // MapEditor.map = LMapWrapper;
+    // initialize content of #map with google maps
     MapEditor.map = GMapWrapper;
-    MapEditor.map.init('map', places);
+    MapEditor.map.init('gmap', places);
 
     MapEditor.panorama = new google.maps.StreetViewPanorama(document.getElementById('panorama'), {
         // switch off fullscreenControl because positioning doesn't work
@@ -653,4 +680,19 @@
         }
     };
 
+    document.getElementById('mapSelector').onclick = function () {
+        MapEditor.closePlace();
+        MapEditor.map.hide();
+
+        if (MapEditor.map === GMapWrapper) {
+            MapEditor.map = LMapWrapper;
+            MapEditor.map.init('lmap', places);
+        } else {
+            MapEditor.map = GMapWrapper;
+            MapEditor.map.init('gmap', places);
+        }
+
+
+    }
+
 })();

views/admin/map_editor.php

@@ -13,7 +13,12 @@
 
 @section(subheader) 
            <span><a href="javascript:;" id="mapName" title="Edit map data"><?= $mapName ?></a></span><!--
-        --><span>
+        --><span class="inline hideOnMobile" id="mapSelection">
+                <button id="mapSelector">
+                    <img src="<?= $_ENV['STATIC_ROOT'] ?>/img/map.svg?rev=<?= REVISION ?>" alt="Map Selector" />
+                </button>
+           </span><!--
+        --><span class="inline hideOnMobile">
                <input type="text" id="jumpCoordinates" placeholder="Insert coordinates here" />
                <button id="jumpButton" disabled >Jump</button>
            </span><!--
@@ -58,7 +63,10 @@
 @endsection
 
 @section(main)
-    <div id="map"></div>
+    <div id="map" class="map">
+        <div id="lmap" class="map"></div>
+        <div id="gmap" class="map"></div>
+    </div>
     <div id="panorama"></div>
     <div id="noPano">
         <p class="bold">No panorama is available for this location.</p>