fix HTML syntax error in account.php

database/migrations/structure/20230409_0214_user_personal_data.sql

@@ -1,5 +0,0 @@
-ALTER TABLE `users`
-ADD `full_name` varchar(255) NOT NULL DEFAULT '',
-ADD `nickname` varchar(255) NOT NULL DEFAULT '',
-ADD `phone` varchar(255) NOT NULL DEFAULT '',
-ADD `id_number` varchar(255) NOT NULL DEFAULT '';

src/Controller/UserController.php

@@ -181,11 +181,6 @@ class UserController implements ISecured
             $user->setPlainPassword($newPassword);
         }
 
-        $user->setFullName($this->request->post('full_name'));
-        $user->setNickname($this->request->post('nickname'));
-        $user->setPhone($this->request->post('phone'));
-        $user->setIdNumber($this->request->post('id_number'));
-
         $this->pdm->saveToDb($user);
 
         $this->request->session()->delete('authenticated_with_google_until');

src/PersistentData/Model/User.php

@@ -8,7 +8,7 @@ class User extends Model implements IUser
 {
     protected static string $table = 'users';
 
-    protected static array $fields = ['email', 'username', 'password', 'type', 'google_sub', 'created', 'full_name', 'nickname', 'phone', 'id_number'];
+    protected static array $fields = ['email', 'username', 'password', 'type', 'google_sub', 'created'];
 
     private static array $types = ['user', 'admin'];
 
@@ -24,14 +24,6 @@ class User extends Model implements IUser
 
     private DateTime $created;
 
-    private string $fullName = '';
-
-    private string $nickname = '';
-
-    private string $phone = '';
-
-    private string $idNumber = '';
-
     public function setEmail(string $email): void
     {
         $this->email = $email;
@@ -74,26 +66,6 @@ class User extends Model implements IUser
         $this->created = new DateTime($created);
     }
 
-    public function setFullName(string $fullName): void
-    {
-        $this->fullName = $fullName;
-    }
-
-    public function setNickname(string $nickname): void
-    {
-        $this->nickname = $nickname;
-    }
-
-    public function setPhone(string $phone): void
-    {
-        $this->phone = $phone;
-    }
-
-    public function setIdNumber(string $idNumber): void
-    {
-        $this->idNumber = $idNumber;
-    }
-
     public function getEmail(): string
     {
         return $this->email;
@@ -129,26 +101,6 @@ class User extends Model implements IUser
         return $this->created->format('Y-m-d H:i:s');
     }
 
-    public function getFullName(): string
-    {
-        return $this->fullName;
-    }
-
-    public function getNickname(): string
-    {
-        return $this->nickname;
-    }
-
-    public function getPhone(): string
-    {
-        return $this->phone;
-    }
-
-    public function getIdNumber(): string
-    {
-        return $this->idNumber;
-    }
-
     public function hasPermission(int $permission): bool
     {
         switch ($permission) {
@@ -168,7 +120,7 @@ class User extends Model implements IUser
 
     public function getDisplayName(): string
     {
-        return $this->nickname ?: $this->fullName ?: $this->username ?: $this->email;
+        return $this->email;
     }
 
     public function checkPassword(string $password): bool

views/account/account.php

@@ -5,7 +5,7 @@
 @section(main)
     <h2>Account</h2>
     <div class="box">
-        <form id="accountForm" action="/account" method="post" data-observe-inputs="email,username,password_new,password_new_confirm,full_name,nickname,phone,id_number">
+        <form id="accountForm" action="/account" method="post" data-observe-inputs="email,username,password_new,password_new_confirm">
             <?php if ($user['password'] !== null && $user['google_sub'] !== null): ?>
                 <p class="justify small">Please confirm your identity with your password or with Google to modify your account.</p>
                 <div class="inputWithButton">
@@ -27,11 +27,6 @@
             <input type="text" class="text big fullWidth marginTop" name="username" placeholder="Username" value="<?= $user['username'] ?>">
             <input type="password" class="text big fullWidth marginTop" name="password_new" placeholder="New password" minlength="6">
             <input type="password" class="text big fullWidth marginTop" name="password_new_confirm" placeholder="New password confirmation" minlength="6">
-            <hr>
-            <input type="text" class="text big fullWidth marginTop" name="full_name" placeholder="Full name" value="<?= $user['full_name'] ?>">
-            <input type="text" class="text big fullWidth marginTop" name="nickname" placeholder="Nickname" value="<?= $user['nickname'] ?>">
-            <input type="text" class="text big fullWidth marginTop" name="phone" placeholder="Phone" value="<?= $user['phone'] ?>">
-            <input type="text" class="text big fullWidth marginTop" name="id_number" placeholder="ID number" value="<?= $user['id_number'] ?>">
             <p id="accountFormError" class="formError justify marginTop"></p>
             <div class="right marginTop">
                 <button type="submit" name="submit" disabled>Save</button>