Compare commits

..
Author SHA1 Message Date
bence ecd1da9cb9 decease session expiration time
rvr-nextgen/pipeline/pr-master There was a failure building this commit
2024-11-26 21:07:04 +01:00
bence 61fd393da1 modernize oauth token handling 2024-11-26 21:07:04 +01:00
5 changed files with 5 additions and 11 deletions

No files matched your search

@@ -1,2 +0,0 @@
ALTER TABLE `oauth_sessions`
MODIFY `nonce` varchar(255) CHARACTER SET ascii COLLATE ascii_bin DEFAULT NULL;
-2
View File
@@ -24,8 +24,6 @@ class MaintainDatabaseCommand extends Command
parent::__construct(); parent::__construct();
$this->userPasswordResetterRepository = new UserPasswordResetterRepository(); $this->userPasswordResetterRepository = new UserPasswordResetterRepository();
$this->oauthTokenRepository = new OAuthTokenRepository();
$this->oauthSessionRepository = new OAuthSessionRepository();
} }
public function configure(): void public function configure(): void
+1 -3
View File
@@ -109,10 +109,8 @@ class OAuthController
'nbf' => $session->getCreatedDate()->getTimestamp(), 'nbf' => $session->getCreatedDate()->getTimestamp(),
'exp' => $token->getExpiresDate()->getTimestamp(), 'exp' => $token->getExpiresDate()->getTimestamp(),
'aud' => $session->getClientId(), 'aud' => $session->getClientId(),
'nonce' => $session->getNonce()
]; ];
if ($session->getNonce() !== null) {
$commonPayload['nonce'] = $session->getNonce();
}
$idTokenPayload = array_merge($commonPayload, $this->getUserInfoInternal( $idTokenPayload = array_merge($commonPayload, $this->getUserInfoInternal(
$this->userRepository->getById($session->getUserId()), $this->userRepository->getById($session->getUserId()),
$session->getScopeArray()) $session->getScopeArray())
+1 -1
View File
@@ -29,7 +29,7 @@ class OAuthSessionController implements IAuthenticationRequired
$clientId = \Container::$request->query('client_id'); $clientId = \Container::$request->query('client_id');
$scope = \Container::$request->query('scope') ? \Container::$request->query('scope'): ''; $scope = \Container::$request->query('scope') ? \Container::$request->query('scope'): '';
$state = \Container::$request->query('state'); $state = \Container::$request->query('state');
$nonce = \Container::$request->query('nonce') ? \Container::$request->query('nonce'): null; $nonce = \Container::$request->query('nonce') ? \Container::$request->query('nonce'): '';
$codeChallenge = \Container::$request->query('code_challenge') ?: null; $codeChallenge = \Container::$request->query('code_challenge') ?: null;
$codeChallengeMethod = \Container::$request->query('code_challenge_method') ?: null; $codeChallengeMethod = \Container::$request->query('code_challenge_method') ?: null;
+3 -3
View File
@@ -19,7 +19,7 @@ class OAuthSession extends Model
private array $scope = []; private array $scope = [];
private ?string $nonce = ''; private string $nonce = '';
private ?string $codeChallenge = null; private ?string $codeChallenge = null;
@@ -52,7 +52,7 @@ class OAuthSession extends Model
$this->setScopeArray(explode(' ', $scope)); $this->setScopeArray(explode(' ', $scope));
} }
public function setNonce(?string $nonce): void public function setNonce(string $nonce): void
{ {
$this->nonce = $nonce; $this->nonce = $nonce;
} }
@@ -125,7 +125,7 @@ class OAuthSession extends Model
return $this->scope; return $this->scope;
} }
public function getNonce(): ?string public function getNonce(): string
{ {
return $this->nonce; return $this->nonce;
} }