feature/start-using-authentication-required-interface #22

Merged
bence merged 2 commits from feature/start-using-authentication-required-interface into master 2023-04-16 17:53:16 +02:00
6 changed files with 45 additions and 37 deletions
Showing only changes of commit a89182b64f - Show all commits

View File

@ -1,7 +1,12 @@
<?php <?php
use SokoWeb\Interfaces\Response\IRedirect; use SokoWeb\Interfaces\Response\IRedirect;
use SokoWeb\Interfaces\Response\IContent;
use SokoWeb\Interfaces\Authentication\IAuthenticationRequired;
use SokoWeb\Interfaces\Authorization\ISecured;
use SokoWeb\Response\Redirect; use SokoWeb\Response\Redirect;
use SokoWeb\Response\HtmlContent;
use SokoWeb\Response\JsonContent;
require '../web.php'; require '../web.php';
@ -22,13 +27,11 @@ if ($match !== null) {
$handler = $route->getHandler(); $handler = $route->getHandler();
$controller = new $handler[0](Container::$request); $controller = new $handler[0](Container::$request);
if ($controller instanceof SokoWeb\Interfaces\Authorization\ISecured) { if (
$authorized = $controller->authorize(); $controller instanceof IAuthenticationRequired &&
} else { $controller->isAuthenticationRequired() &&
$authorized = true; Container::$request->user() === null
} ) {
if (!$authorized) {
Container::$request->session()->set('redirect_after_login', substr($_SERVER['REQUEST_URI'], strlen('/'))); Container::$request->session()->set('redirect_after_login', substr($_SERVER['REQUEST_URI'], strlen('/')));
$response = new Redirect(Container::$routeCollection->getRoute('login')->generateLink(), IRedirect::TEMPORARY); $response = new Redirect(Container::$routeCollection->getRoute('login')->generateLink(), IRedirect::TEMPORARY);
header('Location: ' . $response->getUrl(), true, $response->getHttpCode()); header('Location: ' . $response->getUrl(), true, $response->getHttpCode());
@ -36,23 +39,28 @@ if ($match !== null) {
} }
if ($method === 'post' && !in_array($url, $antiCsrfTokenExceptions) && Container::$request->post('anti_csrf_token') !== Container::$request->session()->get('anti_csrf_token')) { if ($method === 'post' && !in_array($url, $antiCsrfTokenExceptions) && Container::$request->post('anti_csrf_token') !== Container::$request->session()->get('anti_csrf_token')) {
$content = new SokoWeb\Response\JsonContent(['error' => 'no_valid_anti_csrf_token']); $content = new JsonContent(['error' => 'no_valid_anti_csrf_token']);
header('Content-Type: text/html; charset=UTF-8', true, 403); header('Content-Type: text/html; charset=UTF-8', true, 403);
$content->render(); $content->render();
return; return;
} }
if (
!($controller instanceof ISecured) ||
$controller->authorize()
) {
$response = call_user_func([$controller, $handler[1]]); $response = call_user_func([$controller, $handler[1]]);
if ($response instanceof SokoWeb\Interfaces\Response\IContent) { if ($response instanceof IContent) {
header('Content-Type: ' . $response->getContentType() . '; charset=UTF-8'); header('Content-Type: ' . $response->getContentType() . '; charset=UTF-8');
$response->render(); $response->render();
return; return;
} elseif ($response instanceof SokoWeb\Interfaces\Response\IRedirect) { } elseif ($response instanceof IRedirect) {
header('Location: ' . $response->getUrl(), true, $response->getHttpCode()); header('Location: ' . $response->getUrl(), true, $response->getHttpCode());
return; return;
} }
} }
}
$content = new SokoWeb\Response\HtmlContent('error/404'); $content = new HtmlContent('error/404');
header('Content-Type: text/html; charset=UTF-8', true, 404); header('Content-Type: text/html; charset=UTF-8', true, 404);
$content->render(); $content->render();

View File

@ -7,14 +7,14 @@ use RVR\PersistentData\Model\User;
use RVR\Repository\CommunityRepository; use RVR\Repository\CommunityRepository;
use RVR\Repository\CommunityMemberRepository; use RVR\Repository\CommunityMemberRepository;
use RVR\Repository\UserRepository; use RVR\Repository\UserRepository;
use SokoWeb\Interfaces\Authorization\ISecured; use SokoWeb\Interfaces\Authentication\IAuthenticationRequired;
use SokoWeb\Interfaces\Request\IRequest; use SokoWeb\Interfaces\Request\IRequest;
use SokoWeb\Interfaces\Response\IContent; use SokoWeb\Interfaces\Response\IContent;
use SokoWeb\PersistentData\PersistentDataManager; use SokoWeb\PersistentData\PersistentDataManager;
use SokoWeb\Response\HtmlContent; use SokoWeb\Response\HtmlContent;
use SokoWeb\Response\JsonContent; use SokoWeb\Response\JsonContent;
class CommunityController implements ISecured class CommunityController implements IAuthenticationRequired
{ {
private IRequest $request; private IRequest $request;
@ -35,9 +35,9 @@ class CommunityController implements ISecured
$this->communityMemberRepository = new CommunityMemberRepository(); $this->communityMemberRepository = new CommunityMemberRepository();
} }
public function authorize(): bool public function isAuthenticationRequired(): bool
{ {
return $this->request->user() !== null; return true;
} }
public function getCommunityHome(): ?IContent public function getCommunityHome(): ?IContent

View File

@ -2,12 +2,12 @@
use RVR\PersistentData\Model\User; use RVR\PersistentData\Model\User;
use RVR\Repository\CommunityMemberRepository; use RVR\Repository\CommunityMemberRepository;
use SokoWeb\Interfaces\Authorization\ISecured; use SokoWeb\Interfaces\Authentication\IAuthenticationRequired;
use SokoWeb\Interfaces\Request\IRequest; use SokoWeb\Interfaces\Request\IRequest;
use SokoWeb\Interfaces\Response\IContent; use SokoWeb\Interfaces\Response\IContent;
use SokoWeb\Response\HtmlContent; use SokoWeb\Response\HtmlContent;
class HomeController implements ISecured class HomeController implements IAuthenticationRequired
{ {
private IRequest $request; private IRequest $request;
@ -19,9 +19,9 @@ class HomeController implements ISecured
$this->communityMemberRepository = new CommunityMemberRepository(); $this->communityMemberRepository = new CommunityMemberRepository();
} }
public function authorize(): bool public function isAuthenticationRequired(): bool
{ {
return $this->request->user() !== null; return true;
} }
public function getHome(): IContent public function getHome(): IContent

View File

@ -4,14 +4,14 @@ use DateTime;
use RVR\PersistentData\Model\OAuthToken; use RVR\PersistentData\Model\OAuthToken;
use RVR\PersistentData\Model\User; use RVR\PersistentData\Model\User;
use RVR\Repository\OAuthClientRepository; use RVR\Repository\OAuthClientRepository;
use SokoWeb\Interfaces\Authorization\ISecured; use SokoWeb\Interfaces\Authentication\IAuthenticationRequired;
use SokoWeb\Interfaces\Request\IRequest; use SokoWeb\Interfaces\Request\IRequest;
use SokoWeb\Interfaces\Response\IRedirect; use SokoWeb\Interfaces\Response\IRedirect;
use SokoWeb\Response\Redirect; use SokoWeb\Response\Redirect;
use SokoWeb\PersistentData\PersistentDataManager; use SokoWeb\PersistentData\PersistentDataManager;
use SokoWeb\Response\HtmlContent; use SokoWeb\Response\HtmlContent;
class OAuthAuthController implements ISecured class OAuthAuthController implements IAuthenticationRequired
{ {
private IRequest $request; private IRequest $request;
@ -26,9 +26,9 @@ class OAuthAuthController implements ISecured
$this->oAuthClientRepository = new OAuthClientRepository(); $this->oAuthClientRepository = new OAuthClientRepository();
} }
public function authorize(): bool public function isAuthenticationRequired(): bool
{ {
return $this->request->user() !== null; return true;
} }
public function auth() public function auth()

View File

@ -2,7 +2,7 @@
use DateTime; use DateTime;
use SokoWeb\Http\Request; use SokoWeb\Http\Request;
use SokoWeb\Interfaces\Authorization\ISecured; use SokoWeb\Interfaces\Authentication\IAuthenticationRequired;
use SokoWeb\Interfaces\Request\IRequest; use SokoWeb\Interfaces\Request\IRequest;
use SokoWeb\Interfaces\Response\IContent; use SokoWeb\Interfaces\Response\IContent;
use SokoWeb\Interfaces\Response\IRedirect; use SokoWeb\Interfaces\Response\IRedirect;
@ -15,7 +15,7 @@ use SokoWeb\Response\Redirect;
use SokoWeb\Util\JwtParser; use SokoWeb\Util\JwtParser;
use RVR\Repository\UserRepository; use RVR\Repository\UserRepository;
class UserController implements ISecured class UserController implements IAuthenticationRequired
{ {
private IRequest $request; private IRequest $request;
@ -30,9 +30,9 @@ class UserController implements ISecured
$this->userRepository = new UserRepository(); $this->userRepository = new UserRepository();
} }
public function authorize(): bool public function isAuthenticationRequired(): bool
{ {
return $this->request->user() !== null; return true;
} }
public function getAccount(): IContent public function getAccount(): IContent

View File

@ -1,12 +1,12 @@
<?php namespace RVR\Controller; <?php namespace RVR\Controller;
use RVR\Repository\UserRepository; use RVR\Repository\UserRepository;
use SokoWeb\Interfaces\Authorization\ISecured; use SokoWeb\Interfaces\Authentication\IAuthenticationRequired;
use SokoWeb\Interfaces\Request\IRequest; use SokoWeb\Interfaces\Request\IRequest;
use SokoWeb\Interfaces\Response\IContent; use SokoWeb\Interfaces\Response\IContent;
use SokoWeb\Response\JsonContent; use SokoWeb\Response\JsonContent;
class UserSearchController implements ISecured class UserSearchController implements IAuthenticationRequired
{ {
private IRequest $request; private IRequest $request;
@ -18,9 +18,9 @@ class UserSearchController implements ISecured
$this->userRepository = new UserRepository(); $this->userRepository = new UserRepository();
} }
public function authorize(): bool public function isAuthenticationRequired(): bool
{ {
return $this->request->user() !== null; return true;
} }
public function searchUser(): IContent public function searchUser(): IContent