handle errors and exceptions in controllers
All checks were successful
soko-web/pipeline/pr-master This commit looks good

This commit is contained in:
Bence Pőcze 2023-04-18 22:40:01 +02:00
parent 51801d4228
commit ad7b8c3eda
Signed by: bence
GPG Key ID: DC5BD6E95A333E6D

View File

@ -1,5 +1,7 @@
<?php namespace SokoWeb\Response; <?php namespace SokoWeb\Response;
use ErrorException;
use Exception;
use SokoWeb\Interfaces\Response\IRedirect; use SokoWeb\Interfaces\Response\IRedirect;
use SokoWeb\Interfaces\Response\IContent; use SokoWeb\Interfaces\Response\IContent;
use SokoWeb\Interfaces\Authentication\IAuthenticationRequired; use SokoWeb\Interfaces\Authentication\IAuthenticationRequired;
@ -35,6 +37,8 @@ class HttpResponse
string $requestMethod, string $requestMethod,
string $requestUrl string $requestUrl
) { ) {
set_error_handler([$this, 'exceptionsErrorHandler']);
$this->request = $request; $this->request = $request;
$this->dbConnection = $dbConnection; $this->dbConnection = $dbConnection;
$this->routeCollection = $routeCollection; $this->routeCollection = $routeCollection;
@ -44,6 +48,11 @@ class HttpResponse
$this->rawUrl = $requestUrl; $this->rawUrl = $requestUrl;
} }
public function exceptionsErrorHandler($severity, $message, $filename, $lineno)
{
throw new ErrorException($message, 0, $severity, $filename, $lineno);
}
public function render(): void public function render(): void
{ {
$match = $this->routeCollection->match($this->method, $this->parsedUrl['path']); $match = $this->routeCollection->match($this->method, $this->parsedUrl['path']);
@ -81,7 +90,13 @@ class HttpResponse
} }
$this->dbConnection->startTransaction(); $this->dbConnection->startTransaction();
$response = call_user_func([$controller, $handler[1]]); try {
$response = call_user_func([$controller, $handler[1]]);
} catch (Exception $exception) {
$this->dbConnection->rollback();
$this->render500($exception);
return;
}
$this->dbConnection->commit(); $this->dbConnection->commit();
if ($response instanceof IContent) { if ($response instanceof IContent) {
@ -114,4 +129,17 @@ class HttpResponse
header('Content-Type: text/html; charset=UTF-8', true, 404); header('Content-Type: text/html; charset=UTF-8', true, 404);
$content->render(); $content->render();
} }
private function render500(Exception $exception): void
{
if (empty($_ENV['DEV'])) {
$exceptionToPrint = null;
} else {
$exceptionToPrint = (string)$exception;
}
$content = new HtmlContent($this->appConfig['error500View'], ['exceptionToPrint' => $exceptionToPrint]);
header('Content-Type: text/html; charset=UTF-8', true, 500);
$content->render();
}
} }