Merge pull request 'log erros that were already caught' (#28) from feature/error-log into master

Reviewed-on: #28

composer.json

@@ -6,7 +6,8 @@
   "require": {
     "vlucas/phpdotenv": "^5.5",
     "symfony/console": "^5.4",
-    "phpmailer/phpmailer": "^6.8"
+    "phpmailer/phpmailer": "^6.8",
+    "cocur/slugify": "^4.3"
   },
   "require-dev": {
     "phpunit/phpunit": "^9.6",

composer.lock

@@ -4,8 +4,82 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "079e8a8443fdc25cbe3b03322494b73b",
+    "content-hash": "d873b245eaaf660d70c21e06ee4bcf0a",
     "packages": [
+        {
+            "name": "cocur/slugify",
+            "version": "v4.3.0",
+            "source": {
+                "type": "git",
+                "url": "https://github.com/cocur/slugify.git",
+                "reference": "652234ef5f1be844a2ae1c36ad1b4c88b05160f9"
+            },
+            "dist": {
+                "type": "zip",
+                "url": "https://api.github.com/repos/cocur/slugify/zipball/652234ef5f1be844a2ae1c36ad1b4c88b05160f9",
+                "reference": "652234ef5f1be844a2ae1c36ad1b4c88b05160f9",
+                "shasum": ""
+            },
+            "require": {
+                "ext-mbstring": "*",
+                "php": "^7.1 || ~8.0.0 || ~8.1.0 || ~8.2.0"
+            },
+            "conflict": {
+                "symfony/config": "<3.4 || >=4,<4.3",
+                "symfony/dependency-injection": "<3.4 || >=4,<4.3",
+                "symfony/http-kernel": "<3.4 || >=4,<4.3",
+                "twig/twig": "<2.12.1"
+            },
+            "require-dev": {
+                "laravel/framework": "^5.0|^6.0|^7.0|^8.0",
+                "latte/latte": "~2.2",
+                "league/container": "^2.2.0",
+                "mikey179/vfsstream": "~1.6.8",
+                "mockery/mockery": "^1.3",
+                "nette/di": "~2.4",
+                "pimple/pimple": "~1.1",
+                "plumphp/plum": "~0.1",
+                "symfony/config": "^3.4 || ^4.3 || ^5.0 || ^6.0",
+                "symfony/dependency-injection": "^3.4 || ^4.3 || ^5.0 || ^6.0",
+                "symfony/http-kernel": "^3.4 || ^4.3 || ^5.0 || ^6.0",
+                "symfony/phpunit-bridge": "^5.4 || ^6.0",
+                "twig/twig": "^2.12.1 || ~3.0",
+                "zendframework/zend-modulemanager": "~2.2",
+                "zendframework/zend-servicemanager": "~2.2",
+                "zendframework/zend-view": "~2.2"
+            },
+            "type": "library",
+            "autoload": {
+                "psr-4": {
+                    "Cocur\\Slugify\\": "src"
+                }
+            },
+            "notification-url": "https://packagist.org/downloads/",
+            "license": [
+                "MIT"
+            ],
+            "authors": [
+                {
+                    "name": "Florian Eckerstorfer",
+                    "email": "florian@eckerstorfer.co",
+                    "homepage": "https://florian.ec"
+                },
+                {
+                    "name": "Ivo Bathke",
+                    "email": "ivo.bathke@gmail.com"
+                }
+            ],
+            "description": "Converts a string into a slug.",
+            "keywords": [
+                "slug",
+                "slugify"
+            ],
+            "support": {
+                "issues": "https://github.com/cocur/slugify/issues",
+                "source": "https://github.com/cocur/slugify/tree/v4.3.0"
+            },
+            "time": "2022-12-07T19:48:48+00:00"
+        },
         {
             "name": "graham-campbell/result-type",
             "version": "v1.1.1",

dummy.php

@@ -3,12 +3,3 @@
 require 'vendor/autoload.php';
 
 const ROOT = __DIR__;
-
-class Container
-{
-    static SokoWeb\Interfaces\Database\IConnection $dbConnection;
-    static SokoWeb\Interfaces\Database\IAuditLogger $auditLogger;
-    static SokoWeb\Routing\RouteCollection $routeCollection;
-    static SokoWeb\Interfaces\Session\ISessionHandler $sessionHandler;
-    static SokoWeb\Interfaces\Request\IRequest $request;
-}

src/Database/Mysql/Connection.php

@@ -7,48 +7,52 @@ use mysqli;
 
 class Connection implements IConnection
 {
-    private mysqli $connection;
+    private string $host;
+    private string $user;
+    private string $password;
+    private string $db;
+    private int $port;
+    private string $socket;
+    private ?mysqli $connection = null;
 
     public function __construct(string $host, string $user, string $password, string $db, int $port = -1, string $socket = null)
     {
-        if ($port < 0) {
-            $port = (int) ini_get('mysqli.default_port');
-        }
-
-        if ($socket === null) {
-            $socket = (string) ini_get('mysqli.default_socket');
-        }
-
-        mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT);
-        $this->connection = new mysqli($host, $user, $password, $db, $port, $socket);
-        $this->connection->set_charset('utf8mb4');
+        $this->host = $host;
+        $this->user = $user;
+        $this->password = $password;
+        $this->db = $db;
+        $this->port = $port < 0 ? (int) ini_get('mysqli.default_port') : $port;
+        $this->socket = $socket === null ? (string) ini_get('mysqli.default_socket') : $socket;
     }
 
     public function __destruct()
     {
+        if ($this->connection === null) {
+            return;
+        }
         $this->connection->close();
     }
 
     public function startTransaction(): void
     {
-        $this->connection->autocommit(false);
+        $this->getConnection()->autocommit(false);
     }
 
     public function commit(): void
     {
-        $this->connection->commit();
-        $this->connection->autocommit(true);
+        $this->getConnection()->commit();
+        $this->getConnection()->autocommit(true);
     }
 
     public function rollback(): void
     {
-        $this->connection->rollback();
-        $this->connection->autocommit(true);
+        $this->getConnection()->rollback();
+        $this->getConnection()->autocommit(true);
     }
 
     public function query(string $query): ?IResultSet
     {
-        $result = $this->connection->query($query);
+        $result = $this->getConnection()->query($query);
 
         if ($result !== true) {
             return new ResultSet($result);
@@ -59,36 +63,51 @@ class Connection implements IConnection
 
     public function multiQuery(string $query): array
     {
-        $this->connection->multi_query($query);
+        $this->getConnection()->multi_query($query);
 
         $ret = [];
         do {
-            if ($result = $this->connection->store_result()) {
+            if ($result = $this->getConnection()->store_result()) {
                 $ret[] = new ResultSet($result);
             } else {
                 $ret[] = null;
             }
 
-            $this->connection->more_results();
-        } while ($this->connection->next_result());
+            $this->getConnection()->more_results();
+        } while ($this->getConnection()->next_result());
 
         return $ret;
     }
 
     public function prepare(string $query): IStatement
     {
-        $stmt = $this->connection->prepare($query);
+        $stmt = $this->getConnection()->prepare($query);
 
         return new Statement($stmt);
     }
 
     public function lastId(): int
     {
-        return $this->connection->insert_id;
+        return $this->getConnection()->insert_id;
     }
 
     public function getAffectedRows(): int
     {
-        return $this->connection->affected_rows;
+        return $this->getConnection()->affected_rows;
+    }
+
+    private function getConnection(): mysqli
+    {
+        if ($this->connection === null) {
+            $this->createConnection();
+        }
+        return $this->connection;
+    }
+
+    private function createConnection(): void
+    {
+        mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT);
+        $this->connection = new mysqli($this->host, $this->user, $this->password, $this->db, $this->port, $this->socket);
+        $this->connection->set_charset('utf8mb4');
     }
 }

src/Database/Query/Select.php

@@ -97,28 +97,28 @@ class Select
         return $this;
     }
 
-    public function where($column, string $relation = null, $value = null): Select
+    public function where($column, ?string $relation = null, $value = null): Select
     {
         $this->addWhereCondition('AND', $column, $relation, $value);
 
         return $this;
     }
 
-    public function orWhere($column, string $relation = null, $value = null): Select
+    public function orWhere($column, ?string $relation = null, $value = null): Select
     {
         $this->addWhereCondition('OR', $column, $relation, $value);
 
         return $this;
     }
 
-    public function having($column, string $relation = null, $value = null): Select
+    public function having($column, ?string $relation = null, $value = null): Select
     {
         $this->addHavingCondition('AND', $column, $relation, $value);
 
         return $this;
     }
 
-    public function orHaving($column, string $relation = null, $value = null): Select
+    public function orHaving($column, ?string $relation = null, $value = null): Select
     {
         $this->addHavingCondition('OR', $column, $relation, $value);
 
@@ -211,12 +211,12 @@ class Select
         $this->joins[] = [$type, $table, $column1, $relation, $column2];
     }
 
-    private function addWhereCondition(string $logic, $column, string $relation, $value): void
+    private function addWhereCondition(string $logic, $column, ?string $relation, $value): void
     {
         $this->conditions[self::CONDITION_WHERE][] = [$logic, $column, $relation, $value];
     }
 
-    private function addHavingCondition(string $logic, $column, string $relation, $value): void
+    private function addHavingCondition(string $logic, $column, ?string $relation, $value): void
     {
         $this->conditions[self::CONDITION_HAVING][] = [$logic, $column, $relation, $value];
     }
@@ -276,13 +276,12 @@ class Select
             return [(string) $table, $params];
         }
 
-        if ($table instanceof Select)
-        {
+        if ($table instanceof Select) {
             return $table->generateQuery();
         }
 
         if (isset($this->tableAliases[$table])) {
-            $queryString = ($defineAlias ? Utils::backtick($this->tableAliases[$table]) . ' ' . Utils::backtick($table) : Utils::backtick($table));
+            $queryString = $defineAlias ? Utils::backtick($this->tableAliases[$table]) . ' ' . Utils::backtick($table) : Utils::backtick($table);
             return [$queryString, $params];
         }
 
@@ -295,24 +294,17 @@ class Select
             return (string) $column;
         }
 
-        if (is_array($column)) {
-            $out = '';
-
-            if ($column[0]) {
-                list($tableName, $params) = $this->generateTable($column[0]);
-                $out .= $tableName . '.';
+        if (!is_array($column)) {
+            $column = [$this->table, $column];
         }
 
-            $out .= Utils::backtick($column[1]);
-
+        list($tableName, $params) = $this->generateTable($column[0]);
+        $out = $tableName . '.' . Utils::backtick($column[1]);
         if (!empty($column[2])) {
             $out .= ' ' . Utils::backtick($column[2]);
         }
 
         return $out;
-        } else {
-            return Utils::backtick($column);
-        }
     }
 
     private function generateColumns(): string

src/Interfaces/PersistentData/IPersistentDataManager.php

@@ -0,0 +1,24 @@
+<?php namespace SokoWeb\Interfaces\PersistentData;
+
+use Generator;
+use SokoWeb\Database\Query\Select;
+use SokoWeb\PersistentData\Model\Model;
+
+interface IPersistentDataManager
+{
+    public function selectFromDb(Select $select, string $type, bool $useRelations = false, array $withRelations = []);
+
+    public function selectMultipleFromDb(Select $select, string $type, bool $useRelations = false, array $withRelations = []): Generator;
+
+    public function selectFromDbById($id, string $type, bool $useRelations = false, array $withRelations = []);
+
+    public function selectFromDbBySlug(string $slug, string $type, bool $useRelations = false, array $withRelations = []);
+
+    public function loadRelationsFromDb(Model $model, bool $recursive = false, array $withRelations = []): void;
+
+    public function loadMultiRelationsFromDb(array $models, string $relation, bool $useRelations = false, array $withRelations = []): void;
+
+    public function saveToDb(Model $model): void;
+
+    public function deleteFromDb(Model $model): void;
+}

src/Interfaces/Request/IRequest.php

@@ -4,7 +4,7 @@ use SokoWeb\Interfaces\Authentication\IUser;
 
 interface IRequest
 {
-    public function setParsedRouteParams(array &$routeParams): void;
+    public function setParsedRouteParams(array $routeParams): void;
 
     public function getBase(): string;
 

src/Interfaces/Response/IRedirect.php

@@ -6,7 +6,7 @@ interface IRedirect
 
     const TEMPORARY = 2;
 
-    public function getUrl(): string;
+    public function getTarget(): string;
 
     public function getHttpCode(): int;
 }

src/Interfaces/Routing/IRoute.php

@@ -0,0 +1,12 @@
+<?php namespace SokoWeb\Interfaces\Routing;
+
+interface IRoute
+{
+    public function getId(): string;
+
+    public function getHandler(): array;
+
+    public function generateLink(array $parameters = []): string;
+
+    public function testAgainst(array $path): ?array;
+}

src/Interfaces/Routing/IRouteCollection.php

@@ -0,0 +1,16 @@
+<?php namespace SokoWeb\Interfaces\Routing;
+
+use Closure;
+
+interface IRouteCollection
+{
+    public function get(string $id, string $pattern, array $handler): void;
+
+    public function post(string $id, string $pattern, array $handler): void;
+
+    public function group(string $pattern, Closure $group): void;
+
+    public function getRoute(string $id): ?IRoute;
+
+    public function match(string $method, string $uri): ?array;
+}

src/PersistentData/Model/Model.php

@@ -8,6 +8,8 @@ abstract class Model
 
     protected static array $relations = [];
 
+    protected static array $multiRelations = [];
+
     protected $id = null;
 
     private array $snapshot = [];
@@ -27,6 +29,11 @@ abstract class Model
         return static::$relations;
     }
 
+    public static function getMultiRelations(): array
+    {
+        return static::$multiRelations;
+    }
+
     public function setId($id): void
     {
         $this->id = $id;
@@ -41,7 +48,7 @@ abstract class Model
     {
         $array = [];
 
-        foreach (self::getFields() as $key) {
+        foreach (static::getFields() as $key) {
             $method = 'get' . str_replace('_', '', ucwords($key, '_'));
 
             if (method_exists($this, $method)) {

src/PersistentData/Model/ModelWithSlug.php

@@ -0,0 +1,32 @@
+<?php namespace SokoWeb\PersistentData\Model;
+
+use Cocur\Slugify\Slugify;
+
+abstract class ModelWithSlug extends Model
+{
+    protected static string $slugSource;
+
+    protected ?string $slug = null;
+
+    public static function getFields(): array
+    {
+        return array_merge(['id', 'slug'], static::$fields);
+    }
+
+    public function setSlug(?string $slug): void
+    {
+        $this->slug = $slug;
+    }
+
+    public function getSlug(): ?string
+    {
+        return $this->slug;
+    }
+
+    public function generateSlug(): string
+    {
+        $slugSourceGetMethod = 'get' . str_replace('_', '', ucwords(static::$slugSource, '_'));
+        $this->slug = Slugify::create()->slugify($this->$slugSourceGetMethod());
+        return $this->slug;
+    }
+}

src/PersistentData/PersistentDataManager.php

@@ -3,11 +3,27 @@
 use Generator;
 use SokoWeb\Database\Query\Modify;
 use SokoWeb\Database\Query\Select;
+use SokoWeb\Interfaces\Database\IConnection;
+use SokoWeb\Interfaces\Database\IAuditLogger;
 use SokoWeb\Interfaces\Database\IResultSet;
+use SokoWeb\Interfaces\PersistentData\IPersistentDataManager;
 use SokoWeb\PersistentData\Model\Model;
+use SokoWeb\PersistentData\Model\ModelWithSlug;
 
-class PersistentDataManager
+class PersistentDataManager implements IPersistentDataManager
 {
+    const SLUG_MAX_LENGTH = 255;
+
+    private IConnection $dbConnection;
+
+    private ?IAuditLogger $auditLogger;
+
+    public function __construct(IConnection $dbConnection, ?IAuditLogger $auditLogger = null)
+    {
+        $this->dbConnection = $dbConnection;
+        $this->auditLogger = $auditLogger;
+    }
+
     public function selectFromDb(Select $select, string $type, bool $useRelations = false, array $withRelations = [])
     {
         $select = $this->createSelect($select, $type, $useRelations, $withRelations);
@@ -37,19 +53,231 @@ class PersistentDataManager
         }
     }
 
-    public function selectFromDbById($id, string $type, bool $useRelations = false)
+    public function selectFromDbById($id, string $type, bool $useRelations = false, array $withRelations = [])
     {
-        $select = new Select(\Container::$dbConnection);
+        $select = new Select($this->dbConnection);
         $select->whereId($id);
 
-        return $this->selectFromDb($select, $type, $useRelations);
+        return $this->selectFromDb($select, $type, $useRelations, $withRelations);
     }
 
-    public function fillWithData(array &$data, Model $model, array $withRelations = [], ?string $modelKey = null): void
+    public function selectFromDbBySlug(string $slug, string $type, bool $useRelations = false, array $withRelations = [])
+    {
+        $select = new Select($this->dbConnection);
+        $select->where('slug', '=', $slug);
+
+        return $this->selectFromDb($select, $type, $useRelations, $withRelations);
+    }
+
+    public function loadRelationsFromDb(Model $model, bool $recursive = false, array $withRelations = []): void
     {
         $relations = $model::getRelations();
         if (count($withRelations)) {
-            $relations = array_intersect($relations, $withRelations);
+            $relations = array_intersect_key($relations, array_flip($withRelations));
+        }
+
+        foreach ($relations as $relation => $relationType) {
+            $camel = str_replace('_', '', ucwords($relation, '_'));
+
+            $methodGet = 'get' . $camel . 'Id';
+            $methodSet = 'set' . $camel;
+
+            $relationId = $model->$methodGet();
+
+            if ($relationId !== null) {
+                $relationModel = $this->selectFromDbById($relationId, $relationType, $recursive, $withRelations);
+
+                $model->$methodSet($relationModel);
+            }
+        }
+    }
+
+    public function loadMultiRelationsFromDb(array $models, string $relation, bool $useRelations = false, array $withRelations = []): void
+    {
+        if (count($models) === 0) {
+            return;
+        }
+
+        $parentModelType = get_class($models[0]);
+        $relationModelsSetter = 'set' . str_replace('_', '', ucwords($relation, '_'));
+        [$relationModelType, $reverseRelation] = call_user_func([$parentModelType, 'getMultiRelations'])[$relation];
+        $reverseRelationIdGetter = 'get' . str_replace('_', '', ucwords($reverseRelation, '_')) . 'Id';
+
+        $parentModelsById = [];
+        foreach ($models as $model) {
+            $parentModelsById[$model->getId()] = $model;
+        }
+
+        $select = new Select($this->dbConnection);
+        $select->where($reverseRelation . '_id', 'IN', array_keys($parentModelsById));
+
+        $relationsByParentModelId = [];
+        foreach ($this->selectMultipleFromDb($select, $relationModelType, $useRelations, $withRelations) as $relationModel) {
+            $reverseRelationId = $relationModel->$reverseRelationIdGetter();
+            if (!isset($relationsByParentModelId[$reverseRelationId])) {
+                $relationsByParentModelId[$reverseRelationId] = [];
+            }
+            $relationsByParentModelId[$reverseRelationId][] = $relationModel;
+        }
+
+        foreach ($parentModelsById as $parentModelId => $parentModel) {
+            $relationModels = $relationsByParentModelId[$parentModelId] ?? [];
+            $parentModel->$relationModelsSetter($relationModels);
+        }
+    }
+
+    public function saveToDb(Model $model): void
+    {
+        $this->syncRelations($model);
+
+        $modified = $model->toArray();
+        $id = $model->getId();
+
+        $modify = new Modify($this->dbConnection, $model::getTable(), $this->auditLogger);
+
+        if ($id !== null) {
+            $original = $model->getSnapshot();
+            $diff = [];
+
+            foreach ($original as $key => $value) {
+                if ($value === $modified[$key]) {
+                    unset($modified[$key]);
+                } else {
+                    $diff[$key] = ['old' => $value, 'new' => $modified[$key]];
+                }
+            }
+
+            if (count($modified) > 0) {
+                if ($model instanceof ModelWithSlug && isset($modified['slug'])) {
+                    $diff['slug']['new'] = $modified['slug'] = $this->generateUniqueSlug($model, $modified['slug']);
+                }
+
+                $modify->setId($id);
+                $modify->setDiff($diff);
+                $modify->fill($modified);
+                $modify->save();
+            }
+        } else {
+            if ($model instanceof ModelWithSlug) {
+                $slug = $model->generateSlug();
+                $modified['slug'] = $this->generateUniqueSlug($model, $slug);
+            }
+
+            $modify->fill($modified);
+            $modify->save();
+
+            $model->setId($modify->getId());
+        }
+
+        $model->saveSnapshot();
+    }
+
+    public function deleteFromDb(Model $model): void
+    {
+        $modify = new Modify($this->dbConnection, $model::getTable(), $this->auditLogger);
+        $modify->setId($model->getId());
+        $modify->fill($model->toArray());
+        $modify->delete();
+
+        $model->setId(null);
+        $model->resetSnapshot();
+    }
+
+    private function generateUniqueSlug(ModelWithSlug $model, string $notUniqueSlug): string
+    {
+        $numbered = 1;
+
+        do {
+            if ($numbered > 1) {
+                $slug = substr($notUniqueSlug, 0, static::SLUG_MAX_LENGTH - (strlen((string)$numbered) + 1));
+                $slug = $notUniqueSlug . '_' . (string)$numbered;
+            } else {
+                $slug = substr($notUniqueSlug, 0, static::SLUG_MAX_LENGTH);
+            }
+
+            $select = new Select($this->dbConnection, $model::getTable());
+            $select->where('slug', '=', $slug);
+
+            $numbered++;
+        } while ($select->count() != 0);
+
+        $model->setSlug($slug);
+
+        return $slug;
+    }
+
+    private function createSelect(Select $select, string $type, bool $useRelations = false, array $withRelations = []): Select
+    {
+        $table = call_user_func([$type, 'getTable']);
+        $fields = call_user_func([$type, 'getFields']);
+
+        $columns = [];
+
+        foreach ($fields as $field) {
+            $columns[] = [$table, $field];
+        }
+
+        $select->from($table);
+
+        if ($useRelations) {
+            $relations = call_user_func([$type, 'getRelations']);
+            if (count($withRelations)) {
+                $relations = array_intersect_key($relations, array_flip($withRelations));
+            }
+
+            $columns = array_merge($columns, $this->getRelationColumns($table, $relations, $withRelations));
+
+            $this->leftJoinRelations($select, $table, $table, $relations, $withRelations);
+            $select->columns($columns);
+        } else {
+            $select->columns($columns);
+        }
+
+        return $select;
+    }
+
+    private function getRelationColumns(string $table, array $relations, array $withRelations): array
+    {
+        $columns = [];
+
+        foreach ($relations as $relation => $relationType) {
+            $relationTableAlias = $table . '__' . $relation;
+            $relationTable = call_user_func([$relationType, 'getTable']);
+            foreach (call_user_func([$relationType, 'getFields']) as $relationField) {
+                $columns[] = [$relationTableAlias, $relationField, $relation . '__' . $relationField];
+            }
+
+            $relationsOfRelation = call_user_func([$relationType, 'getRelations']);
+            if (count($withRelations)) {
+                $relationsOfRelation = array_intersect_key($relationsOfRelation, array_flip($withRelations));
+            }
+            $columns = array_merge($columns, $this->getRelationColumns($relationTable, $relationsOfRelation, $withRelations));
+        }
+
+        return $columns;
+    }
+
+    private function leftJoinRelations(Select $select, string $table, string $tableAlias, array $relations, array $withRelations): void
+    {
+        foreach ($relations as $relation => $relationType) {
+            $relationTableAlias = $table . '__' . $relation;
+            $relationTable = call_user_func([$relationType, 'getTable']);
+            $select->setTableAliases([$relationTableAlias => $relationTable]);
+            $select->leftJoin($relationTableAlias, [$relationTableAlias, 'id'], '=', [$tableAlias, $relation . '_id']);
+
+            $relationsOfRelation = call_user_func([$relationType, 'getRelations']);
+            if (count($withRelations)) {
+                $relationsOfRelation = array_intersect_key($relationsOfRelation, array_flip($withRelations));
+            }
+            $this->leftJoinRelations($select, $relationTable, $relationTableAlias, $relationsOfRelation, $withRelations);
+        }
+    }
+
+    private function fillWithData(array &$data, Model $model, array $withRelations = [], ?string $modelKey = null): void
+    {
+        $relations = $model::getRelations();
+        if (count($withRelations)) {
+            $relations = array_intersect_key($relations, array_flip($withRelations));
         }
 
         while (key($data)) {
@@ -76,12 +304,19 @@ class PersistentDataManager
 
                 next($data);
             } else if (substr($key, 0, strlen($relation . '__')) === $relation . '__') {
+                if ($data[$relation . '__id'] !== null) {
                     $relationType = current($relations);
                     $relationModel = new $relationType();
                     $this->fillWithData($data, $relationModel, $withRelations, $relation);
 
                     $method = 'set' . str_replace('_', '', ucwords($relation, '_'));
                     $model->$method($relationModel);
+                } else {
+                    while (substr($key, 0, strlen($relation . '__')) === $relation . '__') {
+                        next($data);
+                        $key = key($data);
+                    }
+                }
 
                 next($relations);
             } else {
@@ -92,136 +327,6 @@ class PersistentDataManager
         $model->saveSnapshot();
     }
 
-    public function loadRelationsFromDb(Model $model, bool $recursive): void
-    {
-        foreach ($model::getRelations() as $relation => $relationType) {
-            $camel = str_replace('_', '', ucwords($relation, '_'));
-
-            $methodGet = 'get' . $camel . 'Id';
-            $methodSet = 'set' . $camel;
-
-            $relationId = $model->$methodGet();
-
-            if ($relationId !== null) {
-                $relationModel = $this->selectFromDbById($relationId, $relationType, $recursive);
-
-                $model->$methodSet($relationModel);
-            }
-        }
-    }
-
-    public function saveToDb(Model $model): void
-    {
-        $this->syncRelations($model);
-
-        $modified = $model->toArray();
-        $id = $model->getId();
-
-        $modify = new Modify(\Container::$dbConnection, $model::getTable(), \Container::$auditLogger);
-
-        if ($id !== null) {
-            $original = $model->getSnapshot();
-            $diff = [];
-
-            foreach ($original as $key => $value) {
-                if ($value === $modified[$key]) {
-                    unset($modified[$key]);
-                } else {
-                    $diff[$key] = ['old' => $value, 'new' => $modified[$key]];
-                }
-            }
-
-            if (count($modified) > 0) {
-                $modify->setId($id);
-                $modify->setDiff($diff);
-                $modify->fill($modified);
-                $modify->save();
-            }
-        } else {
-            $modify->fill($modified);
-            $modify->save();
-
-            $model->setId($modify->getId());
-        }
-
-        $model->saveSnapshot();
-    }
-
-    public function deleteFromDb(Model $model): void
-    {
-        $modify = new Modify(\Container::$dbConnection, $model::getTable(), \Container::$auditLogger);
-        $modify->setId($model->getId());
-        $modify->fill($model->toArray());
-        $modify->delete();
-
-        $model->setId(null);
-        $model->resetSnapshot();
-    }
-
-    private function createSelect(Select $select, string $type, bool $useRelations = false, array $withRelations = []): Select
-    {
-        $table = call_user_func([$type, 'getTable']);
-        $fields = call_user_func([$type, 'getFields']);
-
-        $columns = [];
-
-        foreach ($fields as $field) {
-            $columns[] = [$table, $field];
-        }
-
-        $select->from($table);
-
-        if ($useRelations) {
-            $relations = call_user_func([$type, 'getRelations']);
-            if (count($withRelations)) {
-                $relations = array_intersect($relations, $withRelations);
-            }
-
-            $columns = array_merge($columns, $this->getRelationColumns($relations, $withRelations));
-
-            $this->leftJoinRelations($select, $table, $relations, $withRelations);
-            $select->columns($columns);
-        } else {
-            $select->columns($columns);
-        }
-
-        return $select;
-    }
-
-    private function getRelationColumns(array $relations, array $withRelations): array
-    {
-        $columns = [];
-
-        foreach ($relations as $relation => $relationType) {
-            $relationTable = call_user_func([$relationType, 'getTable']);
-            foreach (call_user_func([$relationType, 'getFields']) as $relationField) {
-                $columns[] = [$relationTable, $relationField, $relation . '__' . $relationField];
-            }
-
-            $nextOrderRelations = call_user_func([$relationType, 'getRelations']);
-            if (count($withRelations)) {
-                $nextOrderRelations = array_intersect($nextOrderRelations, $withRelations);
-            }
-            $columns = array_merge($columns, $this->getRelationColumns($nextOrderRelations, $withRelations));
-        }
-
-        return $columns;
-    }
-
-    private function leftJoinRelations(Select $select, string $table, array $relations, array $withRelations): void
-    {
-        foreach ($relations as $relation => $relationType) {
-            $relationTable = call_user_func([$relationType, 'getTable']);
-            $select->leftJoin($relationTable, [$relationTable, 'id'], '=', [$table, $relation . '_id']);
-
-            $nextOrderRelations = call_user_func([$relationType, 'getRelations']);
-            if (count($withRelations)) {
-                $nextOrderRelations = array_intersect($nextOrderRelations, $withRelations);
-            }
-            $this->leftJoinRelations($select, $relationTable, $nextOrderRelations, $withRelations);
-        }
-    }
-
     private function syncRelations(Model $model): void
     {
         foreach ($model::getRelations() as $relation => $relationType) {

src/Request/Request.php

@@ -17,23 +17,23 @@ class Request implements IRequest
 
     private array $headers;
 
-    private Session $session;
+    private ISession $session;
 
     private ?IUser $user = null;
 
     public function __construct(
         string $base,
-        array &$get,
-        array &$post,
+        array $get,
+        array $post,
         array $headers,
-        array &$session,
+        ISession $session,
         IUserRepository $userRepository)
     {
         $this->base = $base;
-        $this->get = &$get;
-        $this->post = &$post;
+        $this->get = $get;
+        $this->post = $post;
         $this->headers = $headers;
-        $this->session = new Session($session);
+        $this->session = $session;
 
         $userId = $this->session->get('userId');
         if ($userId !== null) {
@@ -41,9 +41,9 @@ class Request implements IRequest
         }
     }
 
-    public function setParsedRouteParams(array &$routeParams): void
+    public function setParsedRouteParams(array $routeParams): void
     {
-        $this->routeParams = &$routeParams;
+        $this->routeParams = $routeParams;
     }
 
     public function getBase(): string

src/Response/HttpResponse.php

@@ -64,7 +64,7 @@ class HttpResponse
         list($route, $params) = $match;
         $this->request->setParsedRouteParams($params);
         $handler = $route->getHandler();
-        $controller = new $handler[0]($this->request);
+        $controller = new $handler[0]();
 
         if (
             $controller instanceof IAuthenticationRequired &&
@@ -94,6 +94,7 @@ class HttpResponse
             $response = call_user_func([$controller, $handler[1]]);
         } catch (Exception $exception) {
             $this->dbConnection->rollback();
+            error_log($exception);
             $this->render500($exception);
             return;
         }
@@ -103,7 +104,7 @@ class HttpResponse
             header('Content-Type: ' . $response->getContentType() . '; charset=UTF-8');
             $response->render();
         } elseif ($response instanceof IRedirect) {
-            header('Location: ' . $response->getUrl(), true, $response->getHttpCode());
+            header('Location: ' . $this->getRedirectUrl($response), true, $response->getHttpCode());
         } else {
             $this->render404();
         }
@@ -113,7 +114,7 @@ class HttpResponse
     {
         $this->request->session()->set('redirect_after_login', $this->rawUrl);
         $response = new Redirect($this->routeCollection->getRoute($this->appConfig['loginRouteId'])->generateLink(), IRedirect::TEMPORARY);
-        header('Location: ' . $response->getUrl(), true, $response->getHttpCode());
+        header('Location: ' . $this->getRedirectUrl($response), true, $response->getHttpCode());
     }
 
     private function renderAntiCsrfError(): void
@@ -142,4 +143,13 @@ class HttpResponse
         header('Content-Type: text/html; charset=UTF-8', true, 500);
         $content->render();
     }
+
+    private function getRedirectUrl(IRedirect $redirect): string
+    {
+        $url = $redirect->getTarget();
+        if (preg_match('/^http(s)?/', $url) !== 1) {
+            $url = $this->request->getBase() . $url;
+        }
+        return $url;
+    }
 }

src/Response/Redirect.php

@@ -14,15 +14,9 @@ class Redirect implements IRedirect
         $this->type = $type;
     }
 
-    public function getUrl(): string
+    public function getTarget(): string
     {
-        if (preg_match('/^http(s)?/', $this->target) === 1) {
-            $link = $this->target;
-        } else {
-            $link = \Container::$request->getBase() . $this->target;
-        }
-
-        return $link;
+        return $this->target;
     }
 
     public function getHttpCode(): int

src/Routing/Route.php

@@ -1,6 +1,8 @@
 <?php namespace SokoWeb\Routing;
 
-class Route
+use SokoWeb\Interfaces\Routing\IRoute;
+
+class Route implements IRoute
 {
     private string $id;
 

src/Routing/RouteCollection.php

@@ -1,8 +1,10 @@
 <?php namespace SokoWeb\Routing;
 
 use Closure;
+use SokoWeb\Interfaces\Routing\IRoute;
+use SokoWeb\Interfaces\Routing\IRouteCollection;
 
-class RouteCollection
+class RouteCollection implements IRouteCollection
 {
     private array $routes = [];
 
@@ -32,7 +34,7 @@ class RouteCollection
         array_pop($this->groupStack);
     }
 
-    public function getRoute(string $id): ?Route
+    public function getRoute(string $id): ?IRoute
     {
         if (!isset($this->routes[$id])) {
             return null;

src/Session/DatabaseSessionHandler.php

@@ -3,15 +3,29 @@
 use DateTime;
 use SokoWeb\Database\Query\Modify;
 use SokoWeb\Database\Query\Select;
+use SokoWeb\Interfaces\Database\IConnection;
 use SokoWeb\Interfaces\Database\IResultSet;
 use SokoWeb\Interfaces\Session\ISessionHandler;
 
 class DatabaseSessionHandler implements ISessionHandler
 {
+    private IConnection $dbConnection;
+
+    private string $table;
+
+    private DateTime $shouldBeNewerThan;
+
     private bool $exists = false;
 
     private bool $written = false;
 
+    public function __construct(IConnection $dbConnection, string $table, DateTime $shouldBeNewerThan)
+    {
+        $this->dbConnection = $dbConnection;
+        $this->table = $table;
+        $this->shouldBeNewerThan = $shouldBeNewerThan;
+    }
+
     public function open($savePath, $sessionName): bool
     {
         return true;
@@ -24,24 +38,27 @@ class DatabaseSessionHandler implements ISessionHandler
 
     public function read($id): string
     {
-        $select = new Select(\Container::$dbConnection, 'sessions');
-        $select->columns(['data']);
+        $select = new Select($this->dbConnection, $this->table);
+        $select->columns(['data', 'updated']);
         $select->whereId(substr($id, 0, 32));
 
         $result = $select->execute()->fetch(IResultSet::FETCH_ASSOC);
-
         if ($result === null) {
             return '';
         }
 
         $this->exists = true;
 
+        if (new DateTime($result['updated']) < $this->shouldBeNewerThan) {
+            return '';
+        }
+
         return $result['data'];
     }
 
     public function write($id, $data): bool
     {
-        $modify = new Modify(\Container::$dbConnection, 'sessions');
+        $modify = new Modify($this->dbConnection, $this->table);
 
         if ($this->exists) {
             $modify->setId(substr($id, 0, 32));
@@ -60,7 +77,7 @@ class DatabaseSessionHandler implements ISessionHandler
 
     public function destroy($id): bool
     {
-        $modify = new Modify(\Container::$dbConnection, 'sessions');
+        $modify = new Modify($this->dbConnection, $this->table);
         $modify->setId(substr($id, 0, 32));
         $modify->delete();
 
@@ -93,7 +110,7 @@ class DatabaseSessionHandler implements ISessionHandler
             return true;
         }
 
-        $modify = new Modify(\Container::$dbConnection, 'sessions');
+        $modify = new Modify($this->dbConnection, $this->table);
 
         $modify->setId(substr($id, 0, 32));
         $modify->set('updated', (new DateTime())->format('Y-m-d H:i:s'));

src/View/Linker.php

@@ -97,8 +97,13 @@ class Linker
 
         fwrite($outputFileHandle, $extra[0]);
         while (($line = fgets($inputFileHandle)) !== false) {
+            if (preg_match('/^\s*@include\((.*)\)\s*$/', $line, $matches) === 1) {
+                $include = file_get_contents(ROOT . '/views/' . $matches[1] . '.php');
+                fwrite($outputFileHandle, $include);
+            } else {
                 fwrite($outputFileHandle, $line);
             }
+        }
         fwrite($outputFileHandle, $extra[1]);
 
         fclose($inputFileHandle);
@@ -134,7 +139,7 @@ class Linker
     {
         $output = [];
 
-        if (preg_match('/^[\w\/\.]+$/', $asset) === 1) {
+        if (preg_match('/^http(s)?/', $asset) !== 1) {
             if (
                 empty($_ENV['DEV']) &&
                 filesize(ROOT . '/public/static/' . $asset) < self::INLINE_ASSET_LIMIT

templates/app.php.tpl

@@ -16,10 +16,12 @@ class Container
 {
     static SokoWeb\Interfaces\Database\IConnection $dbConnection;
     static SokoWeb\Interfaces\Database\IAuditLogger $auditLogger;
-    static SokoWeb\Routing\RouteCollection $routeCollection;
+    static SokoWeb\Interfaces\PersistentData\IPersistentDataManager $persistentDataManager;
+    static SokoWeb\Interfaces\Routing\IRouteCollection $routeCollection;
     static SokoWeb\Interfaces\Session\ISessionHandler $sessionHandler;
     static SokoWeb\Interfaces\Request\IRequest $request;
 }
 
 Container::$dbConnection = new SokoWeb\Database\Mysql\Connection($_ENV['DB_HOST'], $_ENV['DB_USER'], $_ENV['DB_PASSWORD'], $_ENV['DB_NAME']);
 Container::$auditLogger = new {app}\Database\AuditLogger(Container::$dbConnection, 'audit_log');
+Container::$persistentDataManager = new SokoWeb\PersistentData\PersistentDataManager(Container::$dbConnection, Container::$auditLogger);

templates/web.php.tpl

@@ -14,7 +14,7 @@ Container::$routeCollection = new SokoWeb\Routing\RouteCollection();
 Container::$routeCollection->get('index', '', [{app}\Controller\HomeController::class, 'getIndex']);
 
 if (isset($_COOKIE['COOKIES_CONSENT'])) {
-    Container::$sessionHandler = new SokoWeb\Session\DatabaseSessionHandler();
+    Container::$sessionHandler = new SokoWeb\Session\DatabaseSessionHandler(Container::$dbConnection, 'sessions');
 
     session_set_save_handler(Container::$sessionHandler, true);
     session_start([