41 Commits
Author SHA1 Message Date
bence ee7d9623a3 set redirect_after_login in query parameter as well
soko-web/pipeline/head This commit looks good
2024-10-24 22:15:22 +02:00
bence ecec258a64 allow starttls and smtps for mailing 2024-10-19 22:44:51 +02:00
bence 66040d69db use IRouteCollection for HttpResponse
soko-web/pipeline/head This commit looks good
2024-10-18 18:18:13 +02:00
bence fc2de8e1ab do not use $_ENV vars for mail template 2024-10-18 18:05:53 +02:00
bence 6cb90d5ea2 Merge pull request 'implement cors' (#30) from implement-cors into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #30
2024-08-02 02:07:28 +02:00
bence e67afc401b implement cors
soko-web/pipeline/pr-master This commit looks good
2024-08-02 01:42:30 +02:00
bence e59d627080 Merge pull request 'feature/update-to-php81' (#29) from feature/update-to-php81 into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #29
2023-09-27 22:11:05 +02:00
bence 3acca19d49 use new interface of TestCase
soko-web/pipeline/pr-master This commit looks good
2023-09-27 22:05:56 +02:00
bence 2226b88a88 adapt signature of DatabaseSessionHandler::gc to the parent class
soko-web/pipeline/pr-master There was a failure building this commit
2023-09-27 21:46:32 +02:00
bence 8e08b09ae8 generate composer.lock
soko-web/pipeline/pr-master There was a failure building this commit
2023-09-27 21:41:17 +02:00
bence a3bce1f2aa update composer packages 2023-09-27 21:38:59 +02:00
bence a84d3a3976 update to php 8.1 2023-09-27 21:35:44 +02:00
bence 7210b24aa3 Merge pull request 'log erros that were already caught' (#28) from feature/error-log into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #28
2023-09-27 00:26:55 +02:00
bence 2d48f20aed log erros that were already caught
soko-web/pipeline/pr-master This commit looks good
2023-09-27 00:04:26 +02:00
bence ebe1fa2aa6 Merge pull request 'lazy create mysql connecion' (#27) from feature/lazy-create-mysql-connection into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #27
2023-09-16 23:56:41 +02:00
bence bccee89c13 lazy create mysql connecion
soko-web/pipeline/pr-master This commit looks good
2023-09-16 13:18:42 +02:00
bence 8bf495c89b Merge pull request 'where should accept $relation as null' (#26) from bugfix/fix-where-closure into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #26
2023-07-08 14:38:40 +02:00
bence 74cb576a2e where should accept $relation as null
soko-web/pipeline/pr-master This commit looks good
2023-07-08 14:36:22 +02:00
bence 4283bc9bb1 Merge pull request 'implement multi relation loading' (#25) from feature/multiple-relations into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #25
2023-06-17 14:32:56 +02:00
bence fc4c3234a7 implement multi relation loading
soko-web/pipeline/pr-master This commit looks good
2023-06-17 14:15:46 +02:00
bence 8d490e48aa Merge pull request 'RVRNEXT-31 change logic of checking external assets' (#24) from bugfix/RVRNEXT-31-allow-special-characters-for-local-assets into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #24
2023-05-28 21:13:20 +02:00
bence 1dcab1abe2 RVRNEXT-31 change logic of checking external assets
soko-web/pipeline/pr-master This commit looks good
2023-05-28 21:00:43 +02:00
bence bda12177eb Merge pull request 'Revert "fix the case when relation is set to null"' (#23) from bugfix/fix-syncrelations into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #23
2023-05-28 15:56:14 +02:00
bence f037de014e Revert "fix the case when relation is set to null"
soko-web/pipeline/pr-master This commit looks good
This reverts commit 25548176bb.
2023-05-28 15:54:54 +02:00
bence 8a1820275d Merge pull request 'iterate in $data until fields for empty relation are over' (#22) from bugfix/fix-model-loading-when-left-join-is-empty into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #22
2023-05-28 15:48:31 +02:00
bence da2801560d iterate in $data until fields for empty relation are over
soko-web/pipeline/pr-master This commit looks good
2023-05-28 15:47:35 +02:00
bence dd855a6d6b Merge pull request 'fix the case when relation is set to null' (#21) from bugfix/fix-when-relation-is-set-to-null into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #21
2023-05-28 15:47:27 +02:00
bence 25548176bb fix the case when relation is set to null
soko-web/pipeline/pr-master This commit looks good
2023-05-28 15:46:13 +02:00
bence f31b801c03 Merge pull request 'generated unique slug should be part of diff' (#20) from bugfix/generated-unique-slug-should-be-part-of-diff into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #20
2023-05-28 15:45:58 +02:00
bence 346b1a0ca9 generated unique slug should be part of diff
soko-web/pipeline/pr-master This commit looks good
2023-05-28 15:45:19 +02:00
bence 6fdd25ae4b Merge pull request 'MAPG-238 include view with @include' (#19) from feature/MAPG-238-include-possibility-for-templating-engine into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #19
2023-05-28 15:45:10 +02:00
bence 754a23706a MAPG-238 include view with @include
soko-web/pipeline/pr-master This commit looks good
2023-05-27 10:56:20 +02:00
bence 78f891fbff Merge pull request 'feature/slug-handling' (#18) from feature/slug-handling into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #18
2023-05-07 01:52:34 +02:00
bence 6989e1dcf3 call static instead of self in Model
soko-web/pipeline/pr-master This commit looks good
2023-05-07 01:51:20 +02:00
bence 1288a33ff6 handle slugs in persistent data manager 2023-05-07 01:51:20 +02:00
bence a5bfc61db8 add class that handles model with slug 2023-05-07 01:51:20 +02:00
bence 9637ebc52b install cocur/slugify 2023-05-06 22:59:49 +02:00
bence 585d469b69 Merge pull request 'use the correct table alias in joins 'on clause'' (#17) from bugfix/fix-multiple-level-join-table-alias into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #17
2023-05-02 18:06:33 +02:00
bence a17db2c79c use the correct table alias in joins 'on clause'
soko-web/pipeline/pr-master This commit looks good
2023-05-02 18:04:35 +02:00
bence fd286c9cff Merge pull request 'check session validity by DatabaseSessionHandler' (#16) from feature/sessions-should-expire into master
soko-web/pipeline/head This commit looks good
Reviewed-on: #16
2023-05-02 12:55:47 +02:00
bence 72fc78220f check session validity by DatabaseSessionHandler
soko-web/pipeline/pr-master This commit looks good
2023-05-02 12:37:31 +02:00
14 changed files with 705 additions and 625 deletions

No files matched your search

+1 -1
View File
@@ -1,4 +1,4 @@
FROM php:7.4.7-cli-buster
FROM php:8.1-cli-bookworm
RUN apt-get update && apt-get install -y unzip
RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer
+4 -3
View File
@@ -5,11 +5,12 @@
"license": "GNU GPL 3.0",
"require": {
"vlucas/phpdotenv": "^5.5",
"symfony/console": "^5.4",
"phpmailer/phpmailer": "^6.8"
"symfony/console": "^6.3",
"phpmailer/phpmailer": "^6.8",
"cocur/slugify": "^4.5"
},
"require-dev": {
"phpunit/phpunit": "^9.6",
"phpunit/phpunit": "^10.3",
"phpstan/phpstan": "^1.10"
},
"autoload": {
Generated
+433 -561
View File
File diff suppressed because it is too large. Load diff
+44 -25
View File
@@ -7,48 +7,52 @@ use mysqli;
class Connection implements IConnection
{
private mysqli $connection;
private string $host;
private string $user;
private string $password;
private string $db;
private int $port;
private string $socket;
private ?mysqli $connection = null;
public function __construct(string $host, string $user, string $password, string $db, int $port = -1, string $socket = null)
{
if ($port < 0) {
$port = (int) ini_get('mysqli.default_port');
}
if ($socket === null) {
$socket = (string) ini_get('mysqli.default_socket');
}
mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT);
$this->connection = new mysqli($host, $user, $password, $db, $port, $socket);
$this->connection->set_charset('utf8mb4');
$this->host = $host;
$this->user = $user;
$this->password = $password;
$this->db = $db;
$this->port = $port < 0 ? (int) ini_get('mysqli.default_port') : $port;
$this->socket = $socket === null ? (string) ini_get('mysqli.default_socket') : $socket;
}
public function __destruct()
{
if ($this->connection === null) {
return;
}
$this->connection->close();
}
public function startTransaction(): void
{
$this->connection->autocommit(false);
$this->getConnection()->autocommit(false);
}
public function commit(): void
{
$this->connection->commit();
$this->connection->autocommit(true);
$this->getConnection()->commit();
$this->getConnection()->autocommit(true);
}
public function rollback(): void
{
$this->connection->rollback();
$this->connection->autocommit(true);
$this->getConnection()->rollback();
$this->getConnection()->autocommit(true);
}
public function query(string $query): ?IResultSet
{
$result = $this->connection->query($query);
$result = $this->getConnection()->query($query);
if ($result !== true) {
return new ResultSet($result);
@@ -59,36 +63,51 @@ class Connection implements IConnection
public function multiQuery(string $query): array
{
$this->connection->multi_query($query);
$this->getConnection()->multi_query($query);
$ret = [];
do {
if ($result = $this->connection->store_result()) {
if ($result = $this->getConnection()->store_result()) {
$ret[] = new ResultSet($result);
} else {
$ret[] = null;
}
$this->connection->more_results();
} while ($this->connection->next_result());
$this->getConnection()->more_results();
} while ($this->getConnection()->next_result());
return $ret;
}
public function prepare(string $query): IStatement
{
$stmt = $this->connection->prepare($query);
$stmt = $this->getConnection()->prepare($query);
return new Statement($stmt);
}
public function lastId(): int
{
return $this->connection->insert_id;
return $this->getConnection()->insert_id;
}
public function getAffectedRows(): int
{
return $this->connection->affected_rows;
return $this->getConnection()->affected_rows;
}
private function getConnection(): mysqli
{
if ($this->connection === null) {
$this->createConnection();
}
return $this->connection;
}
private function createConnection(): void
{
mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT);
$this->connection = new mysqli($this->host, $this->user, $this->password, $this->db, $this->port, $this->socket);
$this->connection->set_charset('utf8mb4');
}
}
+6 -6
View File
@@ -97,28 +97,28 @@ class Select
return $this;
}
public function where($column, string $relation = null, $value = null): Select
public function where($column, ?string $relation = null, $value = null): Select
{
$this->addWhereCondition('AND', $column, $relation, $value);
return $this;
}
public function orWhere($column, string $relation = null, $value = null): Select
public function orWhere($column, ?string $relation = null, $value = null): Select
{
$this->addWhereCondition('OR', $column, $relation, $value);
return $this;
}
public function having($column, string $relation = null, $value = null): Select
public function having($column, ?string $relation = null, $value = null): Select
{
$this->addHavingCondition('AND', $column, $relation, $value);
return $this;
}
public function orHaving($column, string $relation = null, $value = null): Select
public function orHaving($column, ?string $relation = null, $value = null): Select
{
$this->addHavingCondition('OR', $column, $relation, $value);
@@ -211,12 +211,12 @@ class Select
$this->joins[] = [$type, $table, $column1, $relation, $column2];
}
private function addWhereCondition(string $logic, $column, string $relation, $value): void
private function addWhereCondition(string $logic, $column, ?string $relation, $value): void
{
$this->conditions[self::CONDITION_WHERE][] = [$logic, $column, $relation, $value];
}
private function addHavingCondition(string $logic, $column, string $relation, $value): void
private function addHavingCondition(string $logic, $column, ?string $relation, $value): void
{
$this->conditions[self::CONDITION_HAVING][] = [$logic, $column, $relation, $value];
}
@@ -12,8 +12,12 @@ interface IPersistentDataManager
public function selectFromDbById($id, string $type, bool $useRelations = false, array $withRelations = []);
public function selectFromDbBySlug(string $slug, string $type, bool $useRelations = false, array $withRelations = []);
public function loadRelationsFromDb(Model $model, bool $recursive = false, array $withRelations = []): void;
public function loadMultiRelationsFromDb(array $models, string $relation, bool $useRelations = false, array $withRelations = []): void;
public function saveToDb(Model $model): void;
public function deleteFromDb(Model $model): void;
+4 -9
View File
@@ -29,13 +29,6 @@ class Mail
{
$this->body = file_get_contents(ROOT . '/mail/' . $template . '.html');
$baseParameters = [
'APP_NAME' => $_ENV['APP_NAME'],
'BASE_URL' => $_ENV['APP_URL'],
];
$params = array_merge($baseParameters, $params);
foreach ($params as $key => $param) {
$this->body = str_replace('{{' . $key . '}}', $param, $this->body);
}
@@ -51,8 +44,10 @@ class Mail
if (!empty($_ENV['MAIL_HOST'])) {
$mailer->Mailer = 'smtp';
$mailer->Host = $_ENV['MAIL_HOST'];
$mailer->Port = !empty($_ENV['MAIL_PORT']) ? $_ENV['MAIL_PORT'] : 25;
$mailer->SMTPSecure = !empty($_ENV['MAIL_SECURE']) ? $_ENV['MAIL_SECURE'] : '';
$mailer->Port = !empty($_ENV['MAIL_PORT']) ? $_ENV['MAIL_PORT'] : 587;
$secureMaping = ['none' => '', 'starttls' => PHPMailer::ENCRYPTION_STARTTLS, 'smtps' => PHPMailer::ENCRYPTION_SMTPS];
$mailer->SMTPSecure = !empty($_ENV['MAIL_SECURE']) ? $secureMaping[$_ENV['MAIL_SECURE']] : '';
if (!empty($_ENV['MAIL_USER'])) {
$mailer->SMTPAuth = true;
+8 -1
View File
@@ -8,6 +8,8 @@ abstract class Model
protected static array $relations = [];
protected static array $multiRelations = [];
protected $id = null;
private array $snapshot = [];
@@ -27,6 +29,11 @@ abstract class Model
return static::$relations;
}
public static function getMultiRelations(): array
{
return static::$multiRelations;
}
public function setId($id): void
{
$this->id = $id;
@@ -41,7 +48,7 @@ abstract class Model
{
$array = [];
foreach (self::getFields() as $key) {
foreach (static::getFields() as $key) {
$method = 'get' . str_replace('_', '', ucwords($key, '_'));
if (method_exists($this, $method)) {
@@ -0,0 +1,32 @@
<?php namespace SokoWeb\PersistentData\Model;
use Cocur\Slugify\Slugify;
abstract class ModelWithSlug extends Model
{
protected static string $slugSource;
protected ?string $slug = null;
public static function getFields(): array
{
return array_merge(['id', 'slug'], static::$fields);
}
public function setSlug(?string $slug): void
{
$this->slug = $slug;
}
public function getSlug(): ?string
{
return $this->slug;
}
public function generateSlug(): string
{
$slugSourceGetMethod = 'get' . str_replace('_', '', ucwords(static::$slugSource, '_'));
$this->slug = Slugify::create()->slugify($this->$slugSourceGetMethod());
return $this->slug;
}
}
+85 -5
View File
@@ -8,9 +8,12 @@ use SokoWeb\Interfaces\Database\IAuditLogger;
use SokoWeb\Interfaces\Database\IResultSet;
use SokoWeb\Interfaces\PersistentData\IPersistentDataManager;
use SokoWeb\PersistentData\Model\Model;
use SokoWeb\PersistentData\Model\ModelWithSlug;
class PersistentDataManager implements IPersistentDataManager
{
const SLUG_MAX_LENGTH = 255;
private IConnection $dbConnection;
private ?IAuditLogger $auditLogger;
@@ -58,6 +61,14 @@ class PersistentDataManager implements IPersistentDataManager
return $this->selectFromDb($select, $type, $useRelations, $withRelations);
}
public function selectFromDbBySlug(string $slug, string $type, bool $useRelations = false, array $withRelations = [])
{
$select = new Select($this->dbConnection);
$select->where('slug', '=', $slug);
return $this->selectFromDb($select, $type, $useRelations, $withRelations);
}
public function loadRelationsFromDb(Model $model, bool $recursive = false, array $withRelations = []): void
{
$relations = $model::getRelations();
@@ -81,6 +92,40 @@ class PersistentDataManager implements IPersistentDataManager
}
}
public function loadMultiRelationsFromDb(array $models, string $relation, bool $useRelations = false, array $withRelations = []): void
{
if (count($models) === 0) {
return;
}
$parentModelType = get_class($models[0]);
$relationModelsSetter = 'set' . str_replace('_', '', ucwords($relation, '_'));
[$relationModelType, $reverseRelation] = call_user_func([$parentModelType, 'getMultiRelations'])[$relation];
$reverseRelationIdGetter = 'get' . str_replace('_', '', ucwords($reverseRelation, '_')) . 'Id';
$parentModelsById = [];
foreach ($models as $model) {
$parentModelsById[$model->getId()] = $model;
}
$select = new Select($this->dbConnection);
$select->where($reverseRelation . '_id', 'IN', array_keys($parentModelsById));
$relationsByParentModelId = [];
foreach ($this->selectMultipleFromDb($select, $relationModelType, $useRelations, $withRelations) as $relationModel) {
$reverseRelationId = $relationModel->$reverseRelationIdGetter();
if (!isset($relationsByParentModelId[$reverseRelationId])) {
$relationsByParentModelId[$reverseRelationId] = [];
}
$relationsByParentModelId[$reverseRelationId][] = $relationModel;
}
foreach ($parentModelsById as $parentModelId => $parentModel) {
$relationModels = $relationsByParentModelId[$parentModelId] ?? [];
$parentModel->$relationModelsSetter($relationModels);
}
}
public function saveToDb(Model $model): void
{
$this->syncRelations($model);
@@ -103,12 +148,21 @@ class PersistentDataManager implements IPersistentDataManager
}
if (count($modified) > 0) {
if ($model instanceof ModelWithSlug && isset($modified['slug'])) {
$diff['slug']['new'] = $modified['slug'] = $this->generateUniqueSlug($model, $modified['slug']);
}
$modify->setId($id);
$modify->setDiff($diff);
$modify->fill($modified);
$modify->save();
}
} else {
if ($model instanceof ModelWithSlug) {
$slug = $model->generateSlug();
$modified['slug'] = $this->generateUniqueSlug($model, $slug);
}
$modify->fill($modified);
$modify->save();
@@ -129,6 +183,29 @@ class PersistentDataManager implements IPersistentDataManager
$model->resetSnapshot();
}
private function generateUniqueSlug(ModelWithSlug $model, string $notUniqueSlug): string
{
$numbered = 1;
do {
if ($numbered > 1) {
$slug = substr($notUniqueSlug, 0, static::SLUG_MAX_LENGTH - (strlen((string)$numbered) + 1));
$slug = $notUniqueSlug . '_' . (string)$numbered;
} else {
$slug = substr($notUniqueSlug, 0, static::SLUG_MAX_LENGTH);
}
$select = new Select($this->dbConnection, $model::getTable());
$select->where('slug', '=', $slug);
$numbered++;
} while ($select->count() != 0);
$model->setSlug($slug);
return $slug;
}
private function createSelect(Select $select, string $type, bool $useRelations = false, array $withRelations = []): Select
{
$table = call_user_func([$type, 'getTable']);
@@ -150,7 +227,7 @@ class PersistentDataManager implements IPersistentDataManager
$columns = array_merge($columns, $this->getRelationColumns($table, $relations, $withRelations));
$this->leftJoinRelations($select, $table, $relations, $withRelations);
$this->leftJoinRelations($select, $table, $table, $relations, $withRelations);
$select->columns($columns);
} else {
$select->columns($columns);
@@ -180,19 +257,19 @@ class PersistentDataManager implements IPersistentDataManager
return $columns;
}
private function leftJoinRelations(Select $select, string $table, array $relations, array $withRelations): void
private function leftJoinRelations(Select $select, string $table, string $tableAlias, array $relations, array $withRelations): void
{
foreach ($relations as $relation => $relationType) {
$relationTableAlias = $table . '__' . $relation;
$relationTable = call_user_func([$relationType, 'getTable']);
$select->setTableAliases([$relationTableAlias => $relationTable]);
$select->leftJoin($relationTableAlias, [$relationTableAlias, 'id'], '=', [$table, $relation . '_id']);
$select->leftJoin($relationTableAlias, [$relationTableAlias, 'id'], '=', [$tableAlias, $relation . '_id']);
$relationsOfRelation = call_user_func([$relationType, 'getRelations']);
if (count($withRelations)) {
$relationsOfRelation = array_intersect_key($relationsOfRelation, array_flip($withRelations));
}
$this->leftJoinRelations($select, $relationTable, $relationsOfRelation, $withRelations);
$this->leftJoinRelations($select, $relationTable, $relationTableAlias, $relationsOfRelation, $withRelations);
}
}
@@ -235,7 +312,10 @@ class PersistentDataManager implements IPersistentDataManager
$method = 'set' . str_replace('_', '', ucwords($relation, '_'));
$model->$method($relationModel);
} else {
next($data);
while (substr($key, 0, strlen($relation . '__')) === $relation . '__') {
next($data);
$key = key($data);
}
}
next($relations);
+63 -4
View File
@@ -6,12 +6,12 @@ use SokoWeb\Interfaces\Response\IRedirect;
use SokoWeb\Interfaces\Response\IContent;
use SokoWeb\Interfaces\Authentication\IAuthenticationRequired;
use SokoWeb\Interfaces\Authorization\ISecured;
use SokoWeb\Interfaces\Routing\IRouteCollection;
use SokoWeb\Interfaces\Database\IConnection;
use SokoWeb\Interfaces\Request\IRequest;
use SokoWeb\Response\Redirect;
use SokoWeb\Response\HtmlContent;
use SokoWeb\Response\JsonContent;
use SokoWeb\Routing\RouteCollection;
class HttpResponse
{
@@ -19,7 +19,7 @@ class HttpResponse
private IConnection $dbConnection;
private RouteCollection $routeCollection;
private IRouteCollection $routeCollection;
private array $appConfig;
@@ -32,7 +32,7 @@ class HttpResponse
public function __construct(
IRequest $request,
IConnection $dbConnection,
RouteCollection $routeCollection,
IRouteCollection $routeCollection,
array $appConfig,
string $requestMethod,
string $requestUrl
@@ -55,6 +55,11 @@ class HttpResponse
public function render(): void
{
$this->handleCors();
if ($this->method === 'options') {
return;
}
$match = $this->routeCollection->match($this->method, $this->parsedUrl['path']);
if ($match === null) {
$this->render404();
@@ -94,6 +99,7 @@ class HttpResponse
$response = call_user_func([$controller, $handler[1]]);
} catch (Exception $exception) {
$this->dbConnection->rollback();
error_log($exception);
$this->render500($exception);
return;
}
@@ -109,10 +115,63 @@ class HttpResponse
}
}
private function handleCors(): void
{
$origin = $this->request->header('Origin');
if (!$origin) {
return;
}
if (isset($this->appConfig['cors']['allow_origins'])) {
if (in_array($origin, $this->appConfig['cors']['allow_origins']) || in_array('*', $this->appConfig['cors']['allow_origins'])) {
header("Access-Control-Allow-Origin: {$origin}");
}
}
if (!empty($this->appConfig['cors']['allow_credentials'])) {
header('Access-Control-Allow-Credentials: true');
}
if ($this->method !== 'options') {
return;
}
if (isset($this->appConfig['cors']['allow_headers'])) {
$headers = explode(',', $this->request->header('Access-Control-Request-Headers'));
if (in_array('*', $this->appConfig['cors']['allow_headers'])) {
$allow_headers = $headers;
} else {
$allow_headers = array_intersect($this->appConfig['cors']['allow_headers'], $headers);
}
if (count($allow_headers) > 0) {
header('Access-Control-Allow-Headers: ' . join(', ', $allow_headers));
}
}
if (isset($this->appConfig['cors']['allow_methods'])) {
if (in_array('*', $this->appConfig['cors']['allow_methods'])) {
$allow_methods = ['DELETE', 'GET', 'HEAD', 'OPTIONS', 'PATCH', 'POST', 'PUT'];
} else {
$allow_methods = $this->appConfig['cors']['allow_methods'];
}
if (count($allow_methods) > 0) {
header('Access-Control-Allow-Methods: ' . join(', ', $allow_methods));
}
}
$max_age = $this->appConfig['cors']['max_age'] ?? 600;
header("Access-Control-Max-Age: {$max_age}");
}
private function redirectToLogin(): void
{
$this->request->session()->set('redirect_after_login', $this->rawUrl);
$response = new Redirect($this->routeCollection->getRoute($this->appConfig['loginRouteId'])->generateLink(), IRedirect::TEMPORARY);
$response = new Redirect(
$this->routeCollection->getRoute($this->appConfig['loginRouteId'])
->generateLink(['redirect_after_login' => urlencode($this->rawUrl)]),
IRedirect::TEMPORARY);
header('Location: ' . $this->getRedirectUrl($response), true, $response->getHttpCode());
}
+11 -5
View File
@@ -13,14 +13,17 @@ class DatabaseSessionHandler implements ISessionHandler
private string $table;
private DateTime $shouldBeNewerThan;
private bool $exists = false;
private bool $written = false;
public function __construct(IConnection $dbConnection, string $table)
public function __construct(IConnection $dbConnection, string $table, DateTime $shouldBeNewerThan)
{
$this->dbConnection = $dbConnection;
$this->table = $table;
$this->shouldBeNewerThan = $shouldBeNewerThan;
}
public function open($savePath, $sessionName): bool
@@ -36,17 +39,20 @@ class DatabaseSessionHandler implements ISessionHandler
public function read($id): string
{
$select = new Select($this->dbConnection, $this->table);
$select->columns(['data']);
$select->columns(['data', 'updated']);
$select->whereId(substr($id, 0, 32));
$result = $select->execute()->fetch(IResultSet::FETCH_ASSOC);
if ($result === null) {
return '';
}
$this->exists = true;
if (new DateTime($result['updated']) < $this->shouldBeNewerThan) {
return '';
}
return $result['data'];
}
@@ -80,12 +86,12 @@ class DatabaseSessionHandler implements ISessionHandler
return true;
}
public function gc($maxlifetime): bool
public function gc($maxlifetime): int|false
{
// empty on purpose
// old sessions are deleted by MaintainDatabaseCommand
return true;
return 1;
}
public function create_sid(): string
+7 -2
View File
@@ -97,7 +97,12 @@ class Linker
fwrite($outputFileHandle, $extra[0]);
while (($line = fgets($inputFileHandle)) !== false) {
fwrite($outputFileHandle, $line);
if (preg_match('/^\s*@include\((.*)\)\s*$/', $line, $matches) === 1) {
$include = file_get_contents(ROOT . '/views/' . $matches[1] . '.php');
fwrite($outputFileHandle, $include);
} else {
fwrite($outputFileHandle, $line);
}
}
fwrite($outputFileHandle, $extra[1]);
@@ -134,7 +139,7 @@ class Linker
{
$output = [];
if (preg_match('/^[\w\/\.]+$/', $asset) === 1) {
if (preg_match('/^http(s)?/', $asset) !== 1) {
if (
empty($_ENV['DEV']) &&
filesize(ROOT . '/public/static/' . $asset) < self::INLINE_ASSET_LIMIT
+3 -3
View File
@@ -17,7 +17,7 @@ final class GoogleOAuthTest extends TestCase
$redirectUrl = 'http://example.com/oauth';
$requestMock = $this->getMockBuilder(IRequest::class)
->setMethods(['setUrl', 'setMethod', 'setQuery', 'setHeaders', 'send'])
->onlyMethods(['setUrl', 'setMethod', 'setQuery', 'setHeaders', 'send'])
->getMock();
$googleOAuth = new GoogleOAuth($requestMock);
@@ -48,10 +48,10 @@ final class GoogleOAuthTest extends TestCase
$redirectUrl = 'http://example.com/oauth';
$requestMock = $this->getMockBuilder(IRequest::class)
->setMethods(['setUrl', 'setMethod', 'setQuery', 'setHeaders', 'send'])
->onlyMethods(['setUrl', 'setMethod', 'setQuery', 'setHeaders', 'send'])
->getMock();
$responseMock = $this->getMockBuilder(IResponse::class)
->setMethods(['getBody', 'getHeaders'])
->onlyMethods(['getBody', 'getHeaders'])
->getMock();
$googleOAuth = new GoogleOAuth($requestMock);