Bence Pőcze bence
  • Joined on 2020-12-27
bence created branch feature/modify-author in esoko/mapguesser 2021-04-29 00:52:52 +02:00
bence pushed to feature/modify-author at esoko/mapguesser 2021-04-29 00:52:52 +02:00
8800724aa9 generalize author attribution
bence commented on pull request esoko/mapguesser#27 2021-04-29 00:49:02 +02:00
Feature In-Game Compass

Most of the changes comes from #26 so I would merge that first. But this new feature really looks cool, it is like our competitor :D

bence commented on pull request esoko/mapguesser#27 2021-04-29 00:45:30 +02:00
Feature In-Game Compass

So I meant here that this should have the id: <img id="compass" ...

bence commented on pull request esoko/mapguesser#27 2021-04-29 00:43:09 +02:00
Feature In-Game Compass

I would give the id compass to the compass img itself so only the compass graphic would rotate. But then this line should look like this to keep the default translate of the image:

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:32:38 +02:00
feature/return-to-starting-point-button

For semantical reasons I would use div instead of span because span is intended to be an inline element, however this a block element here.

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:28:28 +02:00
feature/return-to-starting-point-button

This semantically belongs to reset (after line 334) and resetRound (after line 360). Yes it will be some ugly code duplication but easier to find there and I plan to refactor this JS in the future.

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:19:10 +02:00
feature/return-to-starting-point-button
bence commented on pull request esoko/mapguesser#26 2021-04-29 00:13:05 +02:00
feature/return-to-starting-point-button

I would modify this as follows:

bence pushed tag Release_2104.3 to esoko/mapguesser 2021-04-27 20:39:45 +02:00
bence deleted branch bugfix/scoring-stuck-at-zero from esoko/mapguesser 2021-04-27 20:38:26 +02:00
bence deleted branch feature/jump-to-specific-coordinates-in-mapeditor from esoko/mapguesser 2021-04-27 20:35:36 +02:00
bence deleted branch feature/MAPG-226-change-timeout-algorithm from esoko/mapguesser 2021-04-27 20:35:28 +02:00
bence commented on pull request esoko/mapguesser#25 2021-04-27 17:52:29 +02:00
jump to coordinate feature added to the header stripe

This may not look perfect on mobile devices so it might be moved to a popup in the future, but I like the feature!

bence commented on pull request esoko/mapguesser#25 2021-04-27 17:40:24 +02:00
jump to coordinate feature added to the header stripe

I would execute context menu -> Format Document on this file in VSCode. Formatting JS files should work well in VSCode without any extension.

bence commented on pull request esoko/mapguesser#25 2021-04-27 17:38:06 +02:00
jump to coordinate feature added to the header stripe

Is this necessary?

bence deleted branch bugfix/change-path-to-renamed-folder from esoko/mapguesser 2021-04-27 17:27:44 +02:00