Bence Pőcze bence
0 Followers · 2 Following
  • Joined on 2020-12-27
Repositories
2
 Projects Packages Public Activity Starred Repositories
1
bence merged pull request esoko/mapguesser#29 2021-04-29 00:58:58 +02:00
fix typo
bence pushed to develop at esoko/mapguesser 2021-04-29 00:58:58 +02:00
58cdc1be8d Merge pull request 'fix typo' (#29) from feature/modify-author into develop
4039202268 fix typo
Compare 2 commits »
bence created pull request esoko/mapguesser#29 2021-04-29 00:58:45 +02:00
fix typo
bence created branch feature/modify-author in esoko/mapguesser 2021-04-29 00:58:26 +02:00
bence pushed to feature/modify-author at esoko/mapguesser 2021-04-29 00:58:26 +02:00
4039202268 fix typo
bence pushed tag Release_2104.3.1 to esoko/mapguesser 2021-04-29 00:56:40 +02:00
bence commented on pull request esoko/mapguesser#26 2021-04-29 00:55:24 +02:00
feature/return-to-starting-point-button

Okay, it turned out for me that this PR is already closed :D Maybe this could still be merged independently or the changes could be merged with #27.

bence deleted branch feature/modify-author from esoko/mapguesser 2021-04-29 00:53:31 +02:00
bence pushed to develop at esoko/mapguesser 2021-04-29 00:53:27 +02:00
4677cc5229 Merge pull request 'generalize author attribution' (#28) from feature/modify-author into develop
8800724aa9 generalize author attribution
Compare 2 commits »
bence merged pull request esoko/mapguesser#28 2021-04-29 00:53:26 +02:00
generalize author attribution
bence created pull request esoko/mapguesser#28 2021-04-29 00:53:09 +02:00
generalize author attribution
bence created branch feature/modify-author in esoko/mapguesser 2021-04-29 00:52:52 +02:00
bence pushed to feature/modify-author at esoko/mapguesser 2021-04-29 00:52:52 +02:00
8800724aa9 generalize author attribution
bence commented on pull request esoko/mapguesser#27 2021-04-29 00:49:02 +02:00
Feature In-Game Compass

Most of the changes comes from #26 so I would merge that first. But this new feature really looks cool, it is like our competitor :D

bence commented on pull request esoko/mapguesser#27 2021-04-29 00:45:30 +02:00
Feature In-Game Compass

So I meant here that this should have the id: <img id="compass" ...

bence commented on pull request esoko/mapguesser#27 2021-04-29 00:43:09 +02:00
Feature In-Game Compass

I would give the id compass to the compass img itself so only the compass graphic would rotate. But then this line should look like this to keep the default translate of the image:

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:33:58 +02:00
feature/return-to-starting-point-button

https://gitea.e5tv.hu/esoko/mapguesser/pulls/26/files#issuecomment-197

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:32:38 +02:00
feature/return-to-starting-point-button

For semantical reasons I would use div instead of span because span is intended to be an inline element, however this a block element here.

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:28:28 +02:00
feature/return-to-starting-point-button

This semantically belongs to reset (after line 334) and resetRound (after line 360). Yes it will be some ugly code duplication but easier to find there and I plan to refactor this JS in the future.

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:19:10 +02:00
feature/return-to-starting-point-button