esoko/mapguesser
esoko/mapguesser
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 18 Wiki Activity

Feature In-Game Compass #27

Merged
balazs merged 11 commits from feature/in-game-compass into develop 2021-04-29 19:15:44 +02:00
Conversation 2 Commits 11 Files Changed 3 +24
balazs commented 2021-04-28 20:54:23 +02:00
Member
Copy Link

Compass
Added a new icon, which shows the direction to north. The direction information is coming from POV heading variable.

**Compass** Added a new icon, which shows the direction to north. The direction information is coming from POV heading variable.
balazs added 6 commits 2021-04-28 20:54:23 +02:00
returns to start when clicked on home symbol
All checks were successful
default-pipeline default-pipeline #126
Details
5c8f3d6fb9
reformatted: added new line breaks to the game.css
All checks were successful
default-pipeline default-pipeline #127
Details
3d52c967b6
tailored the style for the navigation buttons
All checks were successful
default-pipeline default-pipeline #128
Details
854775011c
reverted style tailoring for guess
All checks were successful
default-pipeline default-pipeline #129
Details
08c38c6374
balazs requested review from bence 2021-04-28 20:56:13 +02:00
bence reviewed 2021-04-29 00:43:09 +02:00
public/static/js/game.js Outdated
@ -857,1 +864,4 @@
Game.rewriteGoogleLink();
const heading = Game.panorama.getPov().heading;
document.getElementById("compass").style.transform = "rotate(" + heading + "deg)";
bence commented 2021-04-29 00:43:09 +02:00
Owner
Copy Link

I would give the id compass to the compass img itself so only the compass graphic would rotate. But then this line should look like this to keep the default translate of the image:

        document.getElementById("compass").style.transform = "translateY(-50%) rotate(" + heading + "deg)";
I would give the id `compass` to the compass `img` itself so only the compass graphic would rotate. But then this line should look like this to keep the default translate of the image: ```js document.getElementById("compass").style.transform = "translateY(-50%) rotate(" + heading + "deg)"; ```
bence reviewed 2021-04-29 00:45:30 +02:00
views/game.php
@ -62,0 +62,4 @@
<div id="navigation">
<div id="compass" class="navigationItem">
<span>
<img src="<?= $_ENV['STATIC_ROOT'] ?>/img/circle_background.svg?rev=<?= REVISION ?>" alt="Circle Background" class="circleBackground" />
bence commented 2021-04-29 00:45:30 +02:00
Owner
Copy Link

So I meant here that this should have the id: <img id="compass" ...

It is not a practical issue but for me it seems to be better if not the whole parent div rotates.

So I meant [here](https://gitea.e5tv.hu/esoko/mapguesser/pulls/27/files#issuecomment-201) that this should have the id: `<img id="compass" ...` It is not a practical issue but for me it seems to be better if not the whole parent div rotates.
bence commented 2021-04-29 00:49:02 +02:00
Owner
Copy Link

Most of the changes comes from #26 so I would merge that first. But this new feature really looks cool, it is like our competitor :D

Most of the changes comes from #26 so I would merge that first. But this new feature really looks cool, it is like our competitor :D
balazs changed title from Features Return to Start & In-Game Compass to Feature In-Game Compass 2021-04-29 08:27:50 +02:00
balazs added 8 commits 2021-04-29 09:18:41 +02:00
fixed findings
All checks were successful
default-pipeline default-pipeline #137
Details
ffc4aaf110
Merge branch 'develop' into feature/return-to-starting-point-button
All checks were successful
default-pipeline default-pipeline #138
Details
f0b0de405c
only the image is rotated, not the whole div
All checks were successful
default-pipeline default-pipeline #141
Details
d42280eb10
balazs added 3 commits 2021-04-29 12:12:31 +02:00
replaced spans with divs again and fixed the css issue
All checks were successful
default-pipeline default-pipeline #142
Details
8f0cfd4489
replaced span with div for the compass item
All checks were successful
default-pipeline default-pipeline #143
Details
2a3f2212a7
balazs added 1 commit 2021-04-29 12:39:53 +02:00
clicking on compass sets the heading direction to north
All checks were successful
default-pipeline default-pipeline #144
Details
b22f13887f
bence reviewed 2021-04-29 18:54:37 +02:00
public/static/css/game.css Outdated
@ -174,1 +208,4 @@
}
#navigation {
bottom: 25px;
left: 5px;
bence commented 2021-04-29 18:54:37 +02:00
Owner
Copy Link

This should be 10px as in the other PR: 8f0cfd4489/public/static/css/game.css (L211) Otherwise the buttons will be very close to the left side of a mobile device.

This should be 10px as in the other PR: https://gitea.e5tv.hu/esoko/mapguesser/src/commit/8f0cfd4489f049ee7ced9fcb483bd310d084bfa8/public/static/css/game.css#L211 Otherwise the buttons will be very close to the left side of a mobile device.
bence commented 2021-04-29 18:56:49 +02:00
Owner
Copy Link

Looks good, I had one more finding. But I think #26 can be merged first then the conflicts should solved and this can be also merged. Or what do you prefer, merge the both changes in this PR?

I was too slow again, I see that you merged the other one :D

~~Looks good, I had one more finding. But I think #26 can be merged first then the conflicts should solved and this can be also merged. Or what do you prefer, merge the both changes in this PR?~~ I was too slow again, I see that you merged the other one :D
balazs added 1 commit 2021-04-29 18:59:44 +02:00
increased the left margin for mobile view
All checks were successful
default-pipeline default-pipeline #150
Details
6d3f74f911
balazs added 1 commit 2021-04-29 19:00:14 +02:00
Merge branch 'develop' into feature/in-game-compass
All checks were successful
default-pipeline default-pipeline #151
Details
145cb5f637
bence approved these changes 2021-04-29 19:13:57 +02:00
balazs merged commit 8218883faf into develop 2021-04-29 19:15:44 +02:00
bence deleted branch feature/in-game-compass 2021-04-29 20:03:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
bence
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: esoko/mapguesser#27
No description provided.
Delete Branch "feature/in-game-compass"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?