MAPG-177 refactor GoogleOAuth, Http\Request, Http\Response to be more testable

This commit is contained in:
bence committed 2020-06-26 00:28:37 +02:00
1 parent fd657b4244
commit c06dd1e1d2
6 files changed
+60 -14

No files matched your search

+16 -7
View File
@@ -1,11 +1,10 @@
<?php namespace MapGuesser\Http;
class Request
use MapGuesser\Interfaces\Http\IRequest;
use MapGuesser\Interfaces\Http\IResponse;
class Request implements IRequest
{
const HTTP_GET = 0;
const HTTP_POST = 1;
private string $url;
private int $method;
@@ -14,12 +13,22 @@ class Request
private array $headers = [];
public function __construct(string $url, int $method = self::HTTP_GET)
public function __construct(string $url = '', int $method = self::HTTP_GET)
{
$this->url = $url;
$this->method = $method;
}
public function setUrl(string $url): void
{
$this->url = $url;
}
public function setMethod(int $method): void
{
$this->method = $method;
}
public function setQuery($query)
{
if (is_string($query)) {
@@ -34,7 +43,7 @@ class Request
$this->headers = array_merge($this->headers, $headers);
}
public function send(): Response
public function send(): IResponse
{
$ch = curl_init();
+3 -1
View File
@@ -1,6 +1,8 @@
<?php namespace MapGuesser\Http;
class Response
use MapGuesser\Interfaces\Http\IResponse;
class Response implements IResponse
{
private string $body;