Stuck scoring at zero fixed by regular map area update in session #24

balazs · 2021-04-27T16:50:33+02:00

balazs commented

2021-04-27 16:50:33 +02:00

No description provided.

balazs added 1 commit 2021-04-27 16:50:33 +02:00

area of map is updated in the session at each game preparation to avoid outdated map area and wrong score calculation

default-pipeline default-pipeline #115

Details

845d77ebda

bence reviewed 2021-04-27 17:24:31 +02:00

src/Controller/GameController.php Outdated

						
				@ -93,6 +93,11 @@ class GameController

				                'currentRound' => -1

				            ]);

				        }

				        // update the area of the map in the session in any case

bence commented

2021-04-27 17:24:31 +02:00

I would format it this way to be consistent:

        } else { // update the area of the map in the session in any case
            $state['area'] = $map->getArea();
            $session->set('state', $state);
        }

I would format it this way to be consistent: ```php } else { // update the area of the map in the session in any case $state['area'] = $map->getArea(); $session->set('state', $state); } ```

balazs added 1 commit 2021-04-27 17:35:46 +02:00

refactored comment

default-pipeline default-pipeline #118

Details

be0f7b64b8

balazs added 1 commit 2021-04-27 17:36:20 +02:00

Merge branch 'develop' into bugfix/scoring-stuck-at-zero

default-pipeline default-pipeline #119

Details

508a6899d8

balazs requested review from bence 2021-04-27 17:36:46 +02:00

balazs added 1 commit 2021-04-27 17:55:11 +02:00