esoko/mapguesser
esoko/mapguesser
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 18 Wiki Activity

jump to coordinate feature added to the header stripe #25

Merged
balazs merged 4 commits from feature/jump-to-specific-coordinates-in-mapeditor into develop 2021-04-27 17:56:35 +02:00
Conversation 0 Commits 4 Files Changed 2 +74 -11
balazs commented 2021-04-27 16:51:52 +02:00
Member
Copy Link
No description provided.
balazs added 1 commit 2021-04-27 16:51:53 +02:00
jump to coordinate feature added to the header stripe
All checks were successful
default-pipeline default-pipeline #114
Details
8bc3fda49b
balazs added 1 commit 2021-04-27 17:26:47 +02:00
Merge branch 'develop' into feature/jump-to-specific-coordinates-in-mapeditor
All checks were successful
default-pipeline default-pipeline #117
Details
15e3248ee1
balazs requested review from bence 2021-04-27 17:37:24 +02:00
bence reviewed 2021-04-27 17:38:06 +02:00
public/static/css/map_editor.css Outdated
@ -7,6 +7,10 @@
z-index: 1;
}
#jumpForm {
bence commented 2021-04-27 17:38:06 +02:00
Owner
Copy Link

Is this necessary?

Is this necessary?
balazs commented 2021-04-27 17:46:48 +02:00
Author
Member
Copy Link

True. Not necessary anymore. I wanted to put the text input and button inside a form, but the form tag somehow breaks the template and stops the subheader yield before the form.
I'll remove it.

True. Not necessary anymore. I wanted to put the text input and button inside a form, but the form tag somehow breaks the template and stops the subheader yield before the form. I'll remove it.
bence reviewed 2021-04-27 17:40:24 +02:00
public/static/js/map_editor.js
@ -310,6 +310,21 @@
var placeId = addedPlaces[i].id;
places[tempId].id = placeId;
}
},
bence commented 2021-04-27 17:40:24 +02:00
Owner
Copy Link

I would execute context menu -> Format Document on this file in VSCode. Formatting JS files should work well in VSCode without any extension.

I would execute context menu -> Format Document on this file in VSCode. Formatting JS files should work well in VSCode without any extension.
balazs added 2 commits 2021-04-27 17:50:35 +02:00
bence approved these changes 2021-04-27 17:52:29 +02:00
views/admin/map_editor.php
@ -13,2 +13,3 @@
@section(subheader)
@section(subheader)
<span><a href="javascript:;" id="mapName" title="Edit map data"><?= $mapName ?></a></span><!--
--><span>
bence commented 2021-04-27 17:43:08 +02:00
Owner
Copy Link

This may not look perfect on mobile devices so it might be moved to a popup in the future, but I like the feature!

This may not look perfect on mobile devices so it might be moved to a popup in the future, but I like the feature!
balazs merged commit 092cc63148 into develop 2021-04-27 17:56:35 +02:00
bence deleted branch feature/jump-to-specific-coordinates-in-mapeditor 2021-04-27 20:35:35 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
bence
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: esoko/mapguesser#25
No description provided.
Delete Branch "feature/jump-to-specific-coordinates-in-mapeditor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?