Merge pull request 'use the DateTime object when comparing dates in ExhcnageRateCalculator' (!49 ) from bugfix/fix-current-exchange-rate-calculation into master

Reviewed-on: #49
use the DateTime object when comparing dates in ExhcnageRateCalculator
2023-05-06 13:44:09 +02:00 · 2023-05-06 13:41:17 +02:00 · 2023-05-06 13:21:33 +02:00 · 2023-05-06 13:13:15 +02:00
2 changed files with 2 additions and 2 deletions
@@ -41,7 +41,7 @@ class ExchangeRateCalculator

        $currentExchangeRate = null;
        foreach ($this->exchangeRates[$currency->getId()] as $exchangeRate) {
-            if ($exchangeRate->getValidFrom() > $time) {
+            if ($exchangeRate->getValidFromDate() > $time) {
                break;
            }
            $currentExchangeRate = $exchangeRate;
@@ -48,7 +48,7 @@
            <div class="right marginTop" style="font-size: 0;">
                <button type="submit" name="submit_button"><?= isset($transaction) ? 'Save' : 'Create' ?></button>
                <?php if (isset($transaction)): ?>
-                    <button type="submit" form="deleteTransaction"  name="submit_button" data-confirmation="Are you sure you want to delete this transaction?" class="red marginRight">Delete</button>
+                    <button type="submit" form="deleteTransaction"  name="submit_button" data-confirmation="Are you sure you want to delete this transaction?" class="red marginLeft">Delete</button>
                <?php endif; ?>
            </div>
        </form>
Author	SHA1	Message	Date
bence	361671a362	Merge pull request 'use the DateTime object when comparing dates in ExhcnageRateCalculator' (!49 ) from bugfix/fix-current-exchange-rate-calculation into master rvr-nextgen/pipeline/head This commit looks good Details Reviewed-on: #49	2023-05-06 13:44:09 +02:00
bence	b2babcf30f	use the DateTime object when comparing dates in ExhcnageRateCalculator rvr-nextgen/pipeline/pr-master This commit looks good Details	2023-05-06 13:41:17 +02:00
bence	ea579614b3	Merge pull request 'fix margin of delete button on transaction_edit' (!48 ) from bugfix/layout-fix into master rvr-nextgen/pipeline/head This commit looks good Details Reviewed-on: #48	2023-05-06 13:21:33 +02:00
bence	d8786e74d5	fix margin of delete button on transaction_edit rvr-nextgen/pipeline/pr-master This commit looks good Details	2023-05-06 13:13:15 +02:00