Bence Pőcze bence
0 Followers · 2 Following
  • Joined on 2020-12-27
Repositories
2
 Projects Packages Public Activity Starred Repositories
1
bence commented on pull request esoko/mapguesser#26 2021-04-29 00:33:58 +02:00
feature/return-to-starting-point-button

https://gitea.e5tv.hu/esoko/mapguesser/pulls/26/files#issuecomment-197

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:32:38 +02:00
feature/return-to-starting-point-button

For semantical reasons I would use div instead of span because span is intended to be an inline element, however this a block element here.

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:28:28 +02:00
feature/return-to-starting-point-button

This semantically belongs to reset (after line 334) and resetRound (after line 360). Yes it will be some ugly code duplication but easier to find there and I plan to refactor this JS in the future.

bence commented on pull request esoko/mapguesser#26 2021-04-29 00:19:10 +02:00
feature/return-to-starting-point-button
bence commented on pull request esoko/mapguesser#26 2021-04-29 00:13:05 +02:00
feature/return-to-starting-point-button

I would modify this as follows:

bence pushed tag Release_2104.3 to esoko/mapguesser 2021-04-27 20:39:45 +02:00
bence deleted branch bugfix/scoring-stuck-at-zero from esoko/mapguesser 2021-04-27 20:38:26 +02:00
bence deleted branch feature/jump-to-specific-coordinates-in-mapeditor from esoko/mapguesser 2021-04-27 20:35:36 +02:00
bence deleted branch feature/MAPG-226-change-timeout-algorithm from esoko/mapguesser 2021-04-27 20:35:28 +02:00
bence approved esoko/mapguesser#24 2021-04-27 20:31:40 +02:00
Stuck scoring at zero fixed by regular map area update in session
bence commented on pull request esoko/mapguesser#25 2021-04-27 17:52:29 +02:00
jump to coordinate feature added to the header stripe

This may not look perfect on mobile devices so it might be moved to a popup in the future, but I like the feature!

bence approved esoko/mapguesser#25 2021-04-27 17:52:29 +02:00
jump to coordinate feature added to the header stripe
bence commented on pull request esoko/mapguesser#25 2021-04-27 17:40:24 +02:00
jump to coordinate feature added to the header stripe

I would execute context menu -> Format Document on this file in VSCode. Formatting JS files should work well in VSCode without any extension.

bence commented on pull request esoko/mapguesser#25 2021-04-27 17:38:06 +02:00
jump to coordinate feature added to the header stripe

Is this necessary?

bence deleted branch bugfix/change-path-to-renamed-folder from esoko/mapguesser 2021-04-27 17:27:44 +02:00
bence commented on pull request esoko/mapguesser#24 2021-04-27 17:24:31 +02:00
Stuck scoring at zero fixed by regular map area update in session

I would format it this way to be consistent:

bence approved esoko/mapguesser#23 2021-04-27 17:14:31 +02:00
folder name db changed to database in the path
bence created branch test-branch in esoko/mapguesser 2021-04-25 20:37:37 +02:00
bence pushed to test-branch at esoko/mapguesser 2021-04-25 20:37:37 +02:00
c91ac20b06 test commit